mii/wasmer
1
0
Fork 0
mirror of https://github.com/mii443/wasmer.git synced 2025-12-16 17:18:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clean up and address feedback

Browse Source
This commit is contained in:
Mark McCaskey
2020-06-17 10:59:29 -07:00
parent bfb09543d9
commit f85f4636f3
2 changed files with 1 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/api/src/memory.rs
View File

@@ -185,12 +185,4 @@ impl Memory for LinearMemory {
current_length: mmap.size.bytes().0,
}
}
/// Get the host memory as mutable pointer
///
/// This function is used in the `wasmer_runtime::Instance` to retrieve
/// the host memory pointer and interact with the host memory directly.
fn as_mut_ptr(&self) -> *mut u8 {
self as *const Self as *mut u8
}
}

14
lib/runtime/src/memory.rs
View File

@@ -61,7 +61,7 @@ pub struct MemoryPlan {
pub offset_guard_size: u64,
}
/// Trait for Wasm Memory; TODO: doc this
/// Trait for implementing Wasm Memory used by Wasmer.
pub trait Memory: fmt::Debug {
/// Returns the memory plan for this memory.
fn plan(&self) -> &MemoryPlan;
@@ -69,21 +69,9 @@ pub trait Memory: fmt::Debug {
/// Returns the number of allocated wasm pages.
fn size(&self) -> Pages;
/// Grow the memory by the given number of pages.
fn grow_n_pages(&self, n: u32) -> Result<Pages, MemoryError> {
self.grow(Pages(n))
}
/// Grow memory by the specified amount of wasm pages.
fn grow(&self, delta: Pages) -> Result<Pages, MemoryError>;
/// Return a `VMMemoryDefinition` for exposing the memory to compiled wasm code.
fn vmmemory(&self) -> VMMemoryDefinition;
/// Get the host memory as mutable pointer
///
/// This function is used in the `wasmer_runtime::Instance` to retrieve
/// the host memory pointer and interact with the host memory directly.
// TODO: fix this
fn as_mut_ptr(&self) -> *mut u8; //Self;
}