fix warn

nel_os_kernel/src/interrupt/subscriber.rs

@@ -47,7 +47,7 @@ pub fn unsubscribe(callback: SubscriberCallback) -> Result<(), &'static str> {
 
     for slot in subscribers.iter_mut() {
         if let Some(subscriber) = slot {
-            if subscriber.callback == callback {
+            if core::ptr::fn_addr_eq(subscriber.callback, callback) {
                 *slot = None;
                 return Ok(());
             }

nel_os_kernel/src/vmm/x86_64/intel/cr.rs

@@ -10,11 +10,11 @@ use crate::vmm::x86_64::{
 };
 
 pub fn handle_cr_access(vcpu: &mut IntelVCpu, qual: &QualCr) -> Result<(), &'static str> {
-    match AccessType::try_from(qual.access_type()).unwrap() {
+    match qual.access_type() {
         AccessType::MovTo => match qual.index() {
             0 | 4 => {
-                passthrough_write(vcpu, qual);
-                update_ia32e(vcpu);
+                passthrough_write(vcpu, qual)?;
+                update_ia32e(vcpu)?;
             }
             _ => panic!("Unsupported CR index: {}", qual.index()),
         },
@@ -33,7 +33,7 @@ fn passthrough_read(vcpu: &mut IntelVCpu, qual: &QualCr) -> Result<(), &'static
         _ => panic!("Unsupported CR index: {}", qual.index()),
     };
 
-    set_value(vcpu, qual, value);
+    set_value(vcpu, qual, value)?;
 
     Ok(())
 }
@@ -66,7 +66,7 @@ pub fn update_ia32e(vcpu: &mut IntelVCpu) -> Result<(), &'static str> {
 
     let mut entry_ctrl = super::vmcs::controls::EntryControls::read()?;
     entry_ctrl.set_ia32e_mode_guest(ia32e_enabled);
-    entry_ctrl.write();
+    entry_ctrl.write()?;
 
     let mut efer = vmread(x86::vmx::vmcs::guest::IA32_EFER_FULL)?;
 

nel_os_kernel/src/vmm/x86_64/intel/io.rs

@@ -7,14 +7,7 @@ use crate::{
     vmm::x86_64::intel::{register::GuestRegisters, vmwrite},
 };
 
-#[derive(Default)]
-pub struct Serial {
-    pub ier: u8,
-    pub mcr: u8,
-}
-
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
-
 pub enum InitPhase {
     Uninitialized,
     Phase1,
@@ -23,7 +16,7 @@ pub enum InitPhase {
     Initialized,
 }
 
-enum ReadSel {
+pub enum ReadSel {
     IRR,
     ISR,
 }

nel_os_kernel/src/vmm/x86_64/intel/msr.rs

@@ -92,7 +92,7 @@ pub fn register_msrs(vcpu: &mut IntelVCpu) -> Result<(), MsrError> {
     Ok(())
 }
 
-pub fn update_msrs(vcpu: &mut IntelVCpu) -> Result<(), MsrError> {
+pub fn _update_msrs(vcpu: &mut IntelVCpu) -> Result<(), MsrError> {
     info!("updating MSRs");
     let indices_to_update: alloc::vec::Vec<u32> = vcpu
         .host_msr