mii/mozc
1
0
Fork 0
mirror of https://github.com/mii443/mozc.git synced 2025-08-22 16:15:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove the file path limitation for PRs.

Browse Source 
PiperOrigin-RevId: 601957808
This commit is contained in:
Hiroyuki Komatsu
2024-01-27 07:05:31 +00:00
parent 56f218b850
commit 70d1d5207e
2 changed files with 0 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
.github/pull_request_template.md vendored
View File

@ -4,19 +4,6 @@ A clear and concise description of this pull request.
## Issue IDs
Issue and/or discussion IDs related to this pull request.
## Modified code locations
Files/directories of this pull request.
(e.g. src/data/oss/aux_dictionary.tsv, src/renderer/qt/)
## Confirmation of the acceptable code locations
Check https://github.com/google/mozc/blob/master/CONTRIBUTING.md and
confirm whether all modified files are acceptable for pull requests.
"Yes" or "No"
If the answer is "No", instead of this PR, please file an issue at
https://github.com/google/mozc/issues with your investigations.
## Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).
- OS: [e.g. Windows 11, macOS 13.1, etc]

44
CONTRIBUTING.md
View File

@ -15,47 +15,3 @@ was for a different project), you probably don't need to do it again.
Visit <https://cla.developers.google.com/> to see your current agreements or to
sign a new one.
### Check locations of files and directories you plan to edit
**Pull requests to the Mozc project are limited to the specific directories.**
Files and directories we may accept pull requests:
* files in the [top directory](https://github.com/google/mozc/tree/master/)
* [.github/](https://github.com/google/mozc/tree/master/.github/)
* [docker/](https://github.com/google/mozc/tree/master/docker/)
* [docs/](https://github.com/google/mozc/tree/master/docs/)
* [src/.bazelrc](https://github.com/google/mozc/tree/master/src/.bazelrc)
* [src/bazel/](https://github.com/google/mozc/tree/master/src/bazel/)
* [src/client/](https://github.com/google/mozc/tree/master/src/client/)
* [src/data/](https://github.com/google/mozc/tree/master/src/data/)
* [src/gui/](https://github.com/google/mozc/tree/master/src/gui/)
* [src/mac/](https://github.com/google/mozc/tree/master/src/mac/)
* [src/renderer/](https://github.com/google/mozc/tree/master/src/renderer/)
* [src/server/](https://github.com/google/mozc/tree/master/src/server/)
* [src/unix/](https://github.com/google/mozc/tree/master/src/unix/)
* [src/win32/](https://github.com/google/mozc/tree/master/src/unix/)
* [src/WORKSPACE.bazel](https://github.com/google/mozc/tree/master/src/WORKSPAE.bazel)
#### Why is there such a limitation?
The limitation is due to the Google corporate policy that requires OSS code to
be place under the `third_party` directory in the Google internal source
repository [1]. For Mozc's case, files and directories that accept pull requests
need to be placed under `third_party/mozc` in the internal repository, which is
different from where the internal version of Mozc has been developed.
Unfortunately just moving files and directories becomes a quite complicated
project if it involves multiple build dependencies. The above files and
directories are where the migrations have been completed so far, and the Mozc
team is still working on other files and directories. This is why the above list
exists and keeps growing in an incremental manner.
[1]: [Accepting Contributions](https://opensource.google/documentation/reference/releasing/contributions#thirdparty)
> ### Patched code is third_party code
> Once external patches to a project have been accepted, that code is no longer
> exclusively copyrighted by Google. That means that, like any other open source
> software we use, it is subject to our
> [go/thirdparty](https://opensource.google/documentation/reference/thirdparty)
> policies and must be moved to a third_party directory. This means
> //third_party if stored in Piper.