mirror of
https://github.com/mii443/wasmer.git
synced 2025-12-08 13:48:26 +00:00
adb84e2bf6
We have known memory leaks with extern types. The idea is to change the code so that extern types can hold/own data. This patch does that. A `wasm_externtype_t` holds a `WasmExternType` enum. This enum owns sibling types such as `WasmFunctionType`, `WasmGlobalType`, `WasmTableType` and `WasmMemoryType`. It is those structures that ows the extern types data, like `params` and `results` as `wasm_valtype_vec_t` for `WasmFunctionType`. That way, for example, `wasm_functype_t` can return a pointer to these vec which it owns. A `wasm_externtype_t` continues to be transmuted to `wasm_functype_t` etc. Nothing changes on that side.
58 lines
1.6 KiB
Rust
58 lines
1.6 KiB
Rust
use super::super::store::wasm_store_t;
|
|
use super::super::types::{wasm_ref_t, wasm_table_size_t, wasm_tabletype_t};
|
|
use wasmer::Table;
|
|
|
|
#[allow(non_camel_case_types)]
|
|
pub struct wasm_table_t {
|
|
// maybe needs to hold onto instance
|
|
pub(crate) inner: Table,
|
|
}
|
|
|
|
#[no_mangle]
|
|
pub unsafe extern "C" fn wasm_table_new(
|
|
store: &wasm_store_t,
|
|
table_type: &wasm_tabletype_t,
|
|
init: *const wasm_ref_t,
|
|
) -> Option<Box<wasm_table_t>> {
|
|
let table_type = table_type.inner().table_type.clone();
|
|
let init_val = todo!("get val from init somehow");
|
|
let table = c_try!(Table::new(&store.inner, table_type, init_val));
|
|
|
|
Some(Box::new(wasm_table_t { inner: table }))
|
|
}
|
|
|
|
#[no_mangle]
|
|
pub unsafe extern "C" fn wasm_table_delete(_table: Option<Box<wasm_table_t>>) {}
|
|
|
|
#[no_mangle]
|
|
pub unsafe extern "C" fn wasm_table_copy(wasm_table: &wasm_table_t) -> Box<wasm_table_t> {
|
|
// do shallow copy
|
|
Box::new(wasm_table_t {
|
|
inner: wasm_table.inner.clone(),
|
|
})
|
|
}
|
|
|
|
#[no_mangle]
|
|
pub unsafe extern "C" fn wasm_table_same(
|
|
wasm_table1: &wasm_table_t,
|
|
wasm_table2: &wasm_table_t,
|
|
) -> bool {
|
|
wasm_table1.inner.same(&wasm_table2.inner)
|
|
}
|
|
|
|
#[no_mangle]
|
|
pub unsafe extern "C" fn wasm_table_size(wasm_table: &wasm_table_t) -> usize {
|
|
wasm_table.inner.size() as _
|
|
}
|
|
|
|
#[no_mangle]
|
|
pub unsafe extern "C" fn wasm_table_grow(
|
|
_wasm_table: &mut wasm_table_t,
|
|
_delta: wasm_table_size_t,
|
|
_init: *mut wasm_ref_t,
|
|
) -> bool {
|
|
// TODO: maybe need to look at result to return `true`; also maybe report error here
|
|
//wasm_table.inner.grow(delta, init).is_ok()
|
|
todo!("Blocked on transforming ExternRef into a val type")
|
|
}
|