mii/wasmer
1
0
Fork 0
mirror of https://github.com/mii443/wasmer.git synced 2025-08-24 01:09:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove REVIEW request comments

Browse Source
This commit is contained in:
Mark McCaskey
2021-05-12 10:14:58 -07:00
parent 1082fe1692
commit f8b67c743a
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/compiler-llvm/src/translator/code.rs
View File

@ -4395,7 +4395,6 @@ impl<'ctx, 'a> LLVMFunctionCodeGenerator<'ctx, 'a> {
let res = self.builder.build_select(cmp, v2, v1, "");
let res = self.builder.build_bitcast(res, self.intrinsics.i128_ty, "");
self.state.push1(res);
// REVIEW: do we need to push extra about NaNs here?
}
Operator::F64x2Min => {
// a) check v1 and v2 for NaN
@ -4504,7 +4503,6 @@ impl<'ctx, 'a> LLVMFunctionCodeGenerator<'ctx, 'a> {
let res = self.builder.build_select(cmp, v2, v1, "");
let res = self.builder.build_bitcast(res, self.intrinsics.i128_ty, "");
self.state.push1(res);
// REVIEW: do we need to push extra about NaNs here?
}
Operator::F32Max => {
// This implements the same logic as LLVM's @llvm.maximum
@ -4745,7 +4743,6 @@ impl<'ctx, 'a> LLVMFunctionCodeGenerator<'ctx, 'a> {
let res = self.builder.build_select(cmp, v2, v1, "");
let res = self.builder.build_bitcast(res, self.intrinsics.i128_ty, "");
self.state.push1(res);
// REVIEW: do we need to push extra about NaNs here?
}
Operator::F64x2Max => {
// a) check v1 and v2 for NaN
@ -4854,7 +4851,6 @@ impl<'ctx, 'a> LLVMFunctionCodeGenerator<'ctx, 'a> {
let res = self.builder.build_select(cmp, v2, v1, "");
let res = self.builder.build_bitcast(res, self.intrinsics.i128_ty, "");
self.state.push1(res);
// REVIEW: do we need to push extra about NaNs here?
}
Operator::F32Ceil => {
let (input, info) = self.state.pop1_extra()?;