mii/wasmer
1
0
Fork 0
mirror of https://github.com/mii443/wasmer.git synced 2025-12-06 12:48:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant checks form api::Global::set

Browse Source
This commit is contained in:
Mark McCaskey
2020-09-03 16:53:57 -07:00
parent b40714407b
commit c2a10c4046
1 changed files with 2 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
lib/api/src/externals/global.rs vendored
View File

@@ -43,7 +43,7 @@ impl Global {
});
unsafe {
global
.set(val.clone())
.set_unchecked(val.clone())
.map_err(|e| RuntimeError::new(format!("create global for {:?}: {}", val, e)))?;
};
@@ -76,25 +76,13 @@ impl Global {
/// * The global is not mutable
/// * The type of the `Val` doesn't matches the Global type.
pub fn set(&self, val: Val) -> Result<(), RuntimeError> {
if self.ty().mutability != Mutability::Var {
return Err(RuntimeError::new(
"immutable global cannot be set".to_string(),
));
}
if val.ty() != self.ty().ty {
return Err(RuntimeError::new(format!(
"global of type {:?} cannot be set to {:?}",
self.ty().ty,
val.ty()
)));
}
if !val.comes_from_same_store(&self.store) {
return Err(RuntimeError::new("cross-`Store` values are not supported"));
}
unsafe {
self.global
.set(val)
.map_err(|e| RuntimeError::new(format!("Failed to set global: {}", e)))?;
.map_err(|e| RuntimeError::new(format!("{}", e)))?;
}
Ok(())
}