mii/wasmer
1
0
Fork 0
mirror of https://github.com/mii443/wasmer.git synced 2025-12-09 14:18:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added one more TODO, about the imported/exported memory hack on js

Browse Source
This commit is contained in:
ptitSeb
2023-01-05 09:57:29 +01:00
parent 8d7190b8db
commit b126849c34
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/api/src/js/module.rs
View File

@@ -255,6 +255,14 @@ impl Module {
InstantiationError::DifferentStores,
)));
}
// TODO: refactor this if possible, after the WASIX merge.
// The imported/exported memory does not have the correct properties
// (incorrect size and shared flag) hence when using shared memory its
// failing - the only way to fix it is to resolve the import and use the
// correct memory properties. this regression issue was only found
// in WASIX on the browser as the other areas don't mind that they don't match up
// sharrattj/dash should be able to reproduce this.
let imports_object = js_sys::Object::new();
let mut import_externs: Vec<Extern> = vec![];
for import_type in self.imports() {