mii/wasmer
1
0
Fork 0
mirror of https://github.com/mii443/wasmer.git synced 2025-08-29 11:49:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't mark loads and stores volatile when they're bounds checked at runtime.

Browse Source
This commit is contained in:
Nick Lewycky
2020-05-26 14:30:48 -07:00
parent 3d654d2c25
commit 7a1ac7b843
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
lib/compiler-llvm/src/translator/code.rs
View File

@ -913,18 +913,25 @@ impl<'ctx, 'a> LLVMFunctionCodeGenerator<'ctx, 'a> {
// access written in the user program as opposed to one used by our VM)
// then mark that it can't be delete.
fn mark_memaccess_nodelete(
&self,
_memory_index: MemoryIndex,
&mut self,
memory_index: MemoryIndex,
memaccess: InstructionValue<'ctx>,
) -> Result<(), CompileError> {
// TODO: check the memory_index
// The best we've got is `volatile`.
memaccess.set_volatile(true).unwrap();
if let MemoryCache::Static { base_ptr: _ } = self.ctx.memory(
memory_index,
self.intrinsics,
self.module,
self.memory_plans,
) {
// The best we've got is `volatile`.
// TODO: convert unwrap fail to CompileError
memaccess.set_volatile(true).unwrap();
}
Ok(())
}
fn annotate_user_memaccess(
&self,
&mut self,
memory_index: MemoryIndex,
_memarg: &MemoryImmediate,
alignment: u32,