Move target back into wasmer_types

This commit is contained in:
Syrus Akbary
2025-03-06 11:09:51 +01:00
parent bd13db0c48
commit 78eca7958d
41 changed files with 82 additions and 94 deletions

View File

@ -6,8 +6,7 @@ use super::trampoline::{libcall_trampoline_len, make_libcall_trampolines};
#[cfg(feature = "compiler")]
use crate::{
serialize::SerializableCompilation, types::target::Target, EngineInner, ModuleEnvironment,
ModuleMiddlewareChain,
serialize::SerializableCompilation, EngineInner, ModuleEnvironment, ModuleMiddlewareChain,
};
use crate::{
serialize::{
@ -19,10 +18,12 @@ use crate::{
module::CompileModuleInfo,
relocation::Relocation,
section::{CustomSection, SectionIndex},
target::CpuFeature,
},
ArtifactCreate, Features,
};
#[cfg(feature = "compiler")]
use wasmer_types::target::Target;
use core::mem::MaybeUninit;
use enumset::EnumSet;
use rkyv::rancor::Error as RkyvError;
@ -31,6 +32,7 @@ use shared_buffer::OwnedBuffer;
use std::sync::Arc;
use wasmer_types::{
entity::{ArchivedPrimaryMap, PrimaryMap},
target::CpuFeature,
DeserializeError,
};

View File

@ -4,13 +4,12 @@
//! through normal branch instructions.
use enum_iterator::IntoEnumIterator;
use target_lexicon::Architecture;
use wasmer_types::target::{Architecture, Target};
use wasmer_types::LibCall;
use crate::types::{
relocation::{Relocation, RelocationKind, RelocationTarget},
section::{CustomSection, CustomSectionProtection, SectionBody},
target::Target,
};
// SystemV says that both x16 and x17 are available as intra-procedural scratch

View File

@ -1,15 +1,20 @@
//! This module mainly outputs the `Compiler` trait that custom
//! compilers will need to implement.
use crate::types::{module::CompileModuleInfo, symbols::SymbolRegistry, target::Target};
use crate::types::{module::CompileModuleInfo, symbols::SymbolRegistry};
use crate::{
lib::std::{boxed::Box, sync::Arc},
translator::ModuleMiddleware,
types::{function::Compilation, target::CpuFeature},
types::function::Compilation,
FunctionBodyData, ModuleTranslationState,
};
use enumset::EnumSet;
use wasmer_types::{entity::PrimaryMap, error::CompileError, Features, LocalFunctionIndex};
use wasmer_types::{
entity::PrimaryMap,
error::CompileError,
target::{CpuFeature, Target},
Features, LocalFunctionIndex,
};
use wasmparser::{Validator, WasmFeatures};
/// The compiler configuration options.

View File

@ -11,10 +11,7 @@ use crate::{
lib::std::vec::IntoIter,
register_frame_info, resolve_imports,
serialize::{MetadataHeader, SerializableModule},
types::{
relocation::{RelocationLike, RelocationTarget},
target::{CpuFeature, Target},
},
types::relocation::{RelocationLike, RelocationTarget},
ArtifactBuild, ArtifactBuildFromArchive, ArtifactCreate, Engine, EngineInner, Features,
FrameInfosVariant, FunctionExtent, GlobalFrameInfoRegistration, InstantiationError,
ModuleEnvironment, Tunables,
@ -35,6 +32,7 @@ use crate::object::{emit_compilation, emit_data, get_object_for_target, Object};
use wasmer_types::{
entity::{BoxedSlice, PrimaryMap},
target::{CpuFeature, Target},
ArchivedDataInitializerLocation, ArchivedOwnedDataInitializer, CompileError, DataInitializer,
DataInitializerLike, DataInitializerLocation, DataInitializerLocationLike, DeserializeError,
FunctionIndex, HashAlgorithm, LocalFunctionIndex, MemoryIndex, ModuleInfo,

View File

@ -1,6 +1,6 @@
use super::Engine;
use crate::{types::target::Target, CompilerConfig};
use wasmer_types::{Features, HashAlgorithm};
use crate::CompilerConfig;
use wasmer_types::{target::Target, Features, HashAlgorithm};
/// The Builder contents of `Engine`
pub struct EngineBuilder {

View File

@ -1,6 +1,6 @@
//! Universal compilation.
use crate::{engine::builder::EngineBuilder, types::target::Target};
use crate::engine::builder::EngineBuilder;
#[cfg(not(target_arch = "wasm32"))]
use crate::{
types::{
@ -22,8 +22,8 @@ use std::sync::{Arc, Mutex};
#[cfg(not(target_arch = "wasm32"))]
use wasmer_types::{
entity::PrimaryMap, DeserializeError, FunctionIndex, FunctionType, LocalFunctionIndex,
SignatureIndex,
entity::PrimaryMap, target::Target, DeserializeError, FunctionIndex, FunctionType,
LocalFunctionIndex, SignatureIndex,
};
use wasmer_types::{CompileError, Features, HashAlgorithm};

View File

@ -1,8 +1,8 @@
use crate::engine::error::LinkError;
use crate::types::target::{PointerWidth, Target};
use std::ptr::NonNull;
use wasmer_types::entity::{EntityRef, PrimaryMap};
use wasmer_types::{
target::{PointerWidth, Target},
FunctionType, GlobalType, LocalGlobalIndex, LocalMemoryIndex, LocalTableIndex, LocalTagIndex,
MemoryIndex, MemoryType, ModuleInfo, Pages, TableIndex, TableType, TagKind,
};

View File

@ -4,7 +4,6 @@ use crate::types::{
relocation::{RelocationKind as Reloc, RelocationTarget},
section::{CustomSectionProtection, SectionIndex},
symbols::{Symbol, SymbolRegistry},
target::{Architecture, BinaryFormat, Endianness, Triple},
};
use object::{
elf, macho,
@ -15,6 +14,7 @@ use object::{
SymbolScope,
};
use wasmer_types::entity::PrimaryMap;
use wasmer_types::target::{Architecture, BinaryFormat, Endianness, Triple};
use wasmer_types::LocalFunctionIndex;
const DWARF_SECTION_NAME: &[u8] = b".eh_frame";

View File

@ -9,14 +9,13 @@ use crate::types::{
module::CompileModuleInfo,
relocation::Relocation,
section::{CustomSection, SectionIndex},
target::CpuFeature,
};
use enumset::EnumSet;
use rkyv::{Archive, Deserialize as RkyvDeserialize, Serialize as RkyvSerialize};
use wasmer_types::{
entity::PrimaryMap, DeserializeError, Features, FunctionIndex, LocalFunctionIndex, MemoryIndex,
MemoryStyle, ModuleInfo, OwnedDataInitializer, SerializeError, SignatureIndex, TableIndex,
TableStyle,
entity::PrimaryMap, target::CpuFeature, DeserializeError, Features, FunctionIndex,
LocalFunctionIndex, MemoryIndex, MemoryStyle, ModuleInfo, OwnedDataInitializer, SerializeError,
SignatureIndex, TableIndex, TableStyle,
};
pub use wasmer_types::MetadataHeader;

View File

@ -1,6 +1,5 @@
//! Generic Artifact abstraction for Wasmer Engines.
use crate::types::target::CpuFeature;
use crate::Features;
use enumset::EnumSet;
use std::any::Any;
@ -8,7 +7,8 @@ use std::sync::Arc;
use wasmer_types::entity::PrimaryMap;
use wasmer_types::SerializeError;
use wasmer_types::{
DataInitializerLike, MemoryIndex, MemoryStyle, ModuleInfo, TableIndex, TableStyle,
target::CpuFeature, DataInitializerLike, MemoryIndex, MemoryStyle, ModuleInfo, TableIndex,
TableStyle,
};
/// An `Artifact` is the product that the `Engine`

View File

@ -6,5 +6,4 @@ pub mod module;
pub mod relocation;
pub mod section;
pub mod symbols;
pub mod target;
pub mod unwind;

View File

@ -1,231 +0,0 @@
//! Target configuration
// The clippy::use_self exception is due to a false positive indicating that
// `CpuFeature` should be replaced by `Self`. Attaching the allowance to the
// type itself has no effect, therefore it's disabled for the whole module.
// Feel free to remove this allow attribute once the bug is fixed.
// See https://github.com/rust-lang/rust-clippy/issues/6902
// Same things is now happening with unused-unit for the EnumSetType derivative
#![allow(clippy::unused_unit, clippy::use_self)]
use enumset::{EnumSet, EnumSetType};
use std::str::FromStr;
pub use target_lexicon::{
Aarch64Architecture, Architecture, BinaryFormat, CallingConvention, Endianness, Environment,
OperatingSystem, PointerWidth, Triple, Vendor,
};
use wasmer_types::error::ParseCpuFeatureError;
/// The nomenclature is inspired by the [`cpuid` crate].
/// The list of supported features was initially retrieved from
/// [`cranelift-native`].
///
/// The `CpuFeature` enum values are likely to grow closer to the
/// original `cpuid`. However, we prefer to start small and grow from there.
///
/// If you would like to use a flag that doesn't exist yet here, please
/// open a PR.
///
/// [`cpuid` crate]: https://docs.rs/cpuid/0.1.1/cpuid/enum.CpuFeature.html
/// [`cranelift-native`]: https://github.com/bytecodealliance/cranelift/blob/6988545fd20249b084c53f4761b8c861266f5d31/cranelift-native/src/lib.rs#L51-L92
#[allow(missing_docs, clippy::derived_hash_with_manual_eq)]
#[derive(EnumSetType, Debug, Hash)]
pub enum CpuFeature {
// X86 features
SSE2,
SSE3,
SSSE3,
SSE41,
SSE42,
POPCNT,
AVX,
BMI1,
BMI2,
AVX2,
AVX512DQ,
AVX512VL,
AVX512F,
LZCNT,
// ARM features
NEON,
// Risc-V features
}
impl CpuFeature {
#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
/// Retrieves the features for the current Host
pub fn for_host() -> EnumSet<Self> {
let mut features = EnumSet::new();
if std::is_x86_feature_detected!("sse2") {
features.insert(Self::SSE2);
}
if std::is_x86_feature_detected!("sse3") {
features.insert(Self::SSE3);
}
if std::is_x86_feature_detected!("ssse3") {
features.insert(Self::SSSE3);
}
if std::is_x86_feature_detected!("sse4.1") {
features.insert(Self::SSE41);
}
if std::is_x86_feature_detected!("sse4.2") {
features.insert(Self::SSE42);
}
if std::is_x86_feature_detected!("popcnt") {
features.insert(Self::POPCNT);
}
if std::is_x86_feature_detected!("avx") {
features.insert(Self::AVX);
}
if std::is_x86_feature_detected!("bmi1") {
features.insert(Self::BMI1);
}
if std::is_x86_feature_detected!("bmi2") {
features.insert(Self::BMI2);
}
if std::is_x86_feature_detected!("avx2") {
features.insert(Self::AVX2);
}
if std::is_x86_feature_detected!("avx512dq") {
features.insert(Self::AVX512DQ);
}
if std::is_x86_feature_detected!("avx512vl") {
features.insert(Self::AVX512VL);
}
if std::is_x86_feature_detected!("avx512f") {
features.insert(Self::AVX512F);
}
if std::is_x86_feature_detected!("lzcnt") {
features.insert(Self::LZCNT);
}
features
}
#[cfg(target_arch = "aarch64")]
/// Retrieves the features for the current Host
pub fn for_host() -> EnumSet<Self> {
let mut features = EnumSet::new();
if std::arch::is_aarch64_feature_detected!("neon") {
features.insert(Self::NEON);
}
features
}
#[cfg(not(any(target_arch = "x86", target_arch = "x86_64", target_arch = "aarch64")))]
/// Retrieves the features for the current Host
pub fn for_host() -> EnumSet<Self> {
// We default to an empty hash set
EnumSet::new()
}
/// Retrieves an empty set of `CpuFeature`s.
pub fn set() -> EnumSet<Self> {
// We default to an empty hash set
EnumSet::new()
}
}
// This options should map exactly the GCC options indicated
// here by architectures:
//
// X86: https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html
// ARM: https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html
// Aarch64: https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html
impl FromStr for CpuFeature {
type Err = ParseCpuFeatureError;
fn from_str(s: &str) -> Result<Self, Self::Err> {
match s {
"sse2" => Ok(Self::SSE2),
"sse3" => Ok(Self::SSE3),
"ssse3" => Ok(Self::SSSE3),
"sse4.1" => Ok(Self::SSE41),
"sse4.2" => Ok(Self::SSE42),
"popcnt" => Ok(Self::POPCNT),
"avx" => Ok(Self::AVX),
"bmi" => Ok(Self::BMI1),
"bmi2" => Ok(Self::BMI2),
"avx2" => Ok(Self::AVX2),
"avx512dq" => Ok(Self::AVX512DQ),
"avx512vl" => Ok(Self::AVX512VL),
"avx512f" => Ok(Self::AVX512F),
"lzcnt" => Ok(Self::LZCNT),
"neon" => Ok(Self::NEON),
_ => Err(ParseCpuFeatureError::Missing(s.to_string())),
}
}
}
impl std::fmt::Display for CpuFeature {
fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
write!(
f,
"{}",
match self {
Self::SSE2 => "sse2",
Self::SSE3 => "sse3",
Self::SSSE3 => "ssse3",
Self::SSE41 => "sse4.1",
Self::SSE42 => "sse4.2",
Self::POPCNT => "popcnt",
Self::AVX => "avx",
Self::BMI1 => "bmi",
Self::BMI2 => "bmi2",
Self::AVX2 => "avx2",
Self::AVX512DQ => "avx512dq",
Self::AVX512VL => "avx512vl",
Self::AVX512F => "avx512f",
Self::LZCNT => "lzcnt",
Self::NEON => "neon",
}
)
}
}
/// This is the target that we will use for compiling
/// the WebAssembly ModuleInfo, and then run it.
#[derive(Clone, Debug, PartialEq, Eq, Hash)]
pub struct Target {
triple: Triple,
cpu_features: EnumSet<CpuFeature>,
}
impl Target {
/// Creates a new target given a triple
pub fn new(triple: Triple, cpu_features: EnumSet<CpuFeature>) -> Self {
Self {
triple,
cpu_features,
}
}
/// The triple associated for the target.
pub fn triple(&self) -> &Triple {
&self.triple
}
/// The triple associated for the target.
pub fn cpu_features(&self) -> &EnumSet<CpuFeature> {
&self.cpu_features
}
/// Check if target is a native (eq to host) or not
pub fn is_native(&self) -> bool {
let host = Triple::host();
host.operating_system == self.triple.operating_system
&& host.architecture == self.triple.architecture
}
}
/// The default for the Target will use the HOST as the triple
impl Default for Target {
fn default() -> Self {
Self {
triple: Triple::host(),
cpu_features: CpuFeature::for_host(),
}
}
}