Make parameter name on Model.save() optional.

Signed-off-by: Morgan Funtowicz <morgan@huggingface.co>

bindings/python/src/models.rs

@@ -23,7 +23,22 @@ impl Model {
         ))
     }
 
-    fn save(&self, folder: &str, name: &str) -> PyResult<Vec<String>> {
+    #[args(kwargs = "**")]
+    fn save(&self, folder: &str, kwargs: Option<&PyDict>) -> PyResult<Vec<String>> {
+        let mut name: Option<&str> = None;
+        if let Some(kwargs) = kwargs {
+            for (key, value) in kwargs {
+                let key: &str = key.extract()?;
+                match key {
+                    "name" => {
+                        name = value.extract()?
+                    }
+                    _ => println!("Ignored unknown kwarg option {}", key),
+                }
+            }
+        }
+
+
         let saved: PyResult<Vec<_>> = ToPyResult(
             self.model
                 .execute(|model| model.save(Path::new(folder), name)),

bindings/python/tokenizers/implementations/base_tokenizer.py

@@ -209,14 +209,14 @@ class BaseTokenizer:
         """
         return self._tokenizer.id_to_token(id)
 
-    def save(self, directory: str, name: str):
+    def save(self, directory: str, name: str = None):
         """ Save the current model to the given directory
 
         Args:
             directory: str:
                 A path to the destination directory
 
-            name: str:
+            name: (Optional) str:
                 The name of the tokenizer, to be used in the saved files
         """
-        return self._tokenizer.model.save(directory, name)
+        return self._tokenizer.model.save(directory, name=name)

bindings/python/tokenizers/models/__init__.pyi

@@ -7,7 +7,7 @@ class Model:
     a Model will return a instance of this class when instantiated.
     """
 
-    def save(self, folder: str, name: str) -> List[str]:
+    def save(self, folder: str, name: Optional[str] = None) -> List[str]:
         """ Save the current model
 
         Save the current model in the given folder, using the given name for the various