Avoid breaking changes and let parameter name be Optional.

Signed-off-by: Morgan Funtowicz <morgan@huggingface.co>
This commit is contained in:
Morgan Funtowicz
2020-02-22 14:56:59 +01:00
parent 0fc8be9d69
commit d274a7691d

View File

@@ -23,19 +23,7 @@ impl Model {
))
}
#[args(kwargs = "**")]
fn save(&self, folder: &str, kwargs: Option<&PyDict>) -> PyResult<Vec<String>> {
let mut name: Option<&str> = None;
if let Some(kwargs) = kwargs {
for (key, value) in kwargs {
let key: &str = key.extract()?;
match key {
"name" => name = value.extract()?,
_ => println!("Ignored unknown kwarg option {}", key),
}
}
}
fn save(&self, folder: &str, name: Option<&str>) -> PyResult<Vec<String>> {
let saved: PyResult<Vec<_>> = ToPyResult(
self.model
.execute(|model| model.save(Path::new(folder), name)),