Markus Armbruster efec3dd631 qdev: Replace no_user by cannot_instantiate_with_device_add_yet ...

In an ideal world, machines can be built by wiring devices together
with configuration, not code.  Unfortunately, that's not the world we
live in right now.  We still have quite a few devices that need to be
wired up by code.  If you try to device_add such a device, it'll fail
in sometimes mysterious ways.  If you're lucky, you get an
unmysterious immediate crash.

To protect users from such badness, DeviceClass member no_user used to
make device models unavailable with -device / device_add, but that
regressed in commit 18b6dad.  The device model is still omitted from
help, but is available anyway.

Attempts to fix the regression have been rejected with the argument
that the purpose of no_user isn't clear, and it's prone to misuse.

This commit clarifies no_user's purpose.  Anthony suggested to rename
it cannot_instantiate_with_device_add_yet_due_to_internal_bugs, which
I shorten somewhat to keep checkpatch happy.  While there, make it
bool.

Every use of cannot_instantiate_with_device_add_yet gets a FIXME
comment asking for rationale.  The next few commits will clean them
all up, either by providing a rationale, or by getting rid of the use.

With that done, the regression fix is hopefully acceptable.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel.a@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>

2013-12-23 00:27:22 +01:00

..

a9gtimer.c

hw/timer: Introduce ARM A9 Global Timer.

2013-12-10 13:24:51 +00:00

allwinner-a10-pit.c

hw/timer: add allwinner a10 timer

2013-12-17 20:12:51 +00:00

arm_mptimer.c

qdev: Replace no_user by cannot_instantiate_with_device_add_yet

2013-12-23 00:27:22 +01:00

arm_timer.c

aio / timers: Untangle include files

2013-08-22 19:10:27 +02:00

cadence_ttc.c

aio / timers: Switch entire codebase to the new timer API

2013-08-22 19:14:24 +02:00

digic-timer.c

hw/arm/digic: add timer support

2013-12-17 20:12:51 +00:00

ds1338.c

…

etraxfs_timer.c

aio / timers: Switch entire codebase to the new timer API

2013-08-22 19:14:24 +02:00

exynos4210_mct.c

aio / timers: Switch entire codebase to the new timer API

2013-08-22 19:14:24 +02:00

exynos4210_pwm.c

aio / timers: Untangle include files

2013-08-22 19:10:27 +02:00

exynos4210_rtc.c

misc: Fix some typos in names and comments

2013-09-01 18:59:24 +04:00

grlib_gptimer.c

aio / timers: Untangle include files

2013-08-22 19:10:27 +02:00

hpet.c

qdev: Replace no_user by cannot_instantiate_with_device_add_yet

2013-12-23 00:27:22 +01:00

i8254_common.c

qdev: Replace no_user by cannot_instantiate_with_device_add_yet

2013-12-23 00:27:22 +01:00

i8254.c

aio / timers: Switch entire codebase to the new timer API

2013-08-22 19:14:24 +02:00

imx_epit.c

aio / timers: Untangle include files

2013-08-22 19:10:27 +02:00

imx_gpt.c

aio / timers: Untangle include files

2013-08-22 19:10:27 +02:00

lm32_timer.c

aio / timers: Untangle include files

2013-08-22 19:10:27 +02:00

m48t59.c

qdev: Replace no_user by cannot_instantiate_with_device_add_yet

2013-12-23 00:27:22 +01:00

Makefile.objs

hw/timer: add allwinner a10 timer

2013-12-17 20:12:51 +00:00

mc146818rtc.c

qdev: Replace no_user by cannot_instantiate_with_device_add_yet

2013-12-23 00:27:22 +01:00

milkymist-sysctl.c

milkymist-sysctl: QOM cast cleanup

2013-07-29 21:07:01 +02:00

omap_gptimer.c

aio / timers: Switch entire codebase to the new timer API

2013-08-22 19:14:24 +02:00

omap_synctimer.c

aio / timers: Switch entire codebase to the new timer API

2013-08-22 19:14:24 +02:00

pl031.c

qdev: Replace no_user by cannot_instantiate_with_device_add_yet

2013-12-23 00:27:22 +01:00

puv3_ost.c

aio / timers: Untangle include files

2013-08-22 19:10:27 +02:00

pxa2xx_timer.c

aio / timers: Switch entire codebase to the new timer API

2013-08-22 19:14:24 +02:00

sh_timer.c

aio / timers: Untangle include files

2013-08-22 19:10:27 +02:00

slavio_timer.c

aio / timers: Untangle include files

2013-08-22 19:10:27 +02:00

tusb6010.c

aio / timers: Switch entire codebase to the new timer API

2013-08-22 19:14:24 +02:00

twl92230.c

aio / timers: Switch entire codebase to the new timer API

2013-08-22 19:14:24 +02:00

xilinx_timer.c

aio / timers: Untangle include files

2013-08-22 19:10:27 +02:00