Markus Armbruster 4dd32b3dda migration: Fix !replay_can_snapshot() error handling ...

Calling error_report() in a function that takes an Error ** argument
is suspicious.  save_snapshot() and load_snapshot() do that, and then
fail without setting an error.  Wrong.  The HMP commands survive this
unscathed, since hmp_handle_error() does nothing when no error has
been set.  Callers main() (on behalf of -loadvm) and
replay_vmstate_init() crash, but I'm not sure the error is possible
there.

Screwed up when commit 377b21ccea (v2.12.0) added incorrect error
handling right next to correct examples.  Fix by calling error_setg()
instead of error_report().

Fixes: 377b21ccea
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20181017082702.5581-13-armbru@redhat.com>

2018-10-19 14:51:34 +02:00

..

block-dirty-bitmap.c

dirty-bitmap: fix double lock on bitmap enabling

2018-07-04 02:12:49 -04:00

block.c

migration/block: compare only read blocks against the rate limiter

2018-03-23 16:45:18 +00:00

block.h

migration: disable auto-converge during bulk block migration

2017-09-27 11:27:14 +01:00

channel.c

Migration+TLS: Fix crash due to double cleanup

2018-05-15 22:13:08 +02:00

channel.h

migration: Route errors down through migration_channel_connect

2018-02-06 10:55:12 +00:00

colo-comm.c

migration: pre_save return int

2017-09-27 11:35:59 +01:00

colo-failover.c

Include less of the generated modular QAPI headers

2018-03-02 13:45:50 -06:00

colo.c

migration: implement bi-directional RDMA QIOChannel

2018-08-22 12:12:26 +02:00

exec.c

migration: unify incoming processing

2018-07-10 12:48:53 +01:00

exec.h

migration: Export exec.c functions in its own file

2017-06-01 18:49:22 +02:00

fd.c

migration: unify incoming processing

2018-07-10 12:48:53 +01:00

fd.h

migration: Export fd.c functions in its own file

2017-06-01 18:49:22 +02:00

global_state.c

migration: pre_save return int

2017-09-27 11:35:59 +01:00

Makefile.objs

migration: add postcopy migration of dirty bitmaps

2018-03-13 17:06:09 -04:00

migration.c

error: Fix use of error_prepend() with &error_fatal, &error_abort

2018-10-19 14:51:34 +02:00

migration.h

migration: do not wait for free thread

2018-08-22 12:34:11 +02:00

page_cache.c

migration: use local path for local headers

2018-06-01 19:20:38 +03:00

page_cache.h

migration: Make cache_init() take an error parameter

2017-10-23 18:03:25 +02:00

postcopy-ram.c

migration: Stop postcopy fault thread before notifying

2018-10-11 19:58:26 +01:00

postcopy-ram.h

postcopy: drop ram_pages parameter from postcopy_ram_incoming_init()

2018-06-27 13:28:31 +02:00

qemu-file-channel.c

migration: invoke qio_channel_yield only when qemu_in_coroutine()

2018-08-22 12:13:59 +02:00

qemu-file-channel.h

migration: Export qemu-file-channel.c functions in its own file

2017-05-18 19:20:50 +02:00

qemu-file.c

migration: disable RDMA WRITE after postcopy started

2018-08-22 12:12:07 +02:00

qemu-file.h

migration: stop compression to allocate and free memory frequently

2018-04-25 18:04:06 +01:00

qjson.c

qobject: Replace qobject_incref/QINCREF qobject_decref/QDECREF

2018-05-04 08:27:53 +02:00

qjson.h

typedefs: add QJSON

2018-06-15 14:40:56 +01:00

ram.c

migration/ram.c: Avoid taking address of fields in packed MultiFDInit_t struct

2018-09-26 17:29:01 +01:00

ram.h

migration: show the statistics of compression

2018-09-26 12:27:27 +01:00

rdma.c

migration/rdma: Fix uninitialised rdma_return_path

2018-09-26 12:21:33 +01:00

rdma.h

migration: Export rdma.c functions in its own file

2017-06-01 18:49:23 +02:00

savevm.c

migration: Fix !replay_can_snapshot() error handling

2018-10-19 14:51:34 +02:00

savevm.h

migration: introduce SaveVMHandlers.resume_prepare

2018-05-15 20:56:55 +02:00

socket.c

migration: unify incoming processing

2018-07-10 12:48:53 +01:00

socket.h

migration: Export functions to create send channels

2018-05-15 20:24:27 +02:00

tls.c

qio: non-default context for TLS handshake

2018-03-06 10:19:07 +00:00

tls.h

migration: Export tls.c functions in its own file

2017-06-01 18:49:23 +02:00

trace-events

Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20180627' into staging

2018-06-28 15:31:42 +01:00

vmstate-types.c

migration: Route more error paths

2017-09-27 11:44:18 +01:00

vmstate.c

migration: Correctly handle subsections with no 'needed' function

2018-08-22 11:40:47 +02:00

xbzrle.c

migration: Create migration/xbzrle.h

2017-05-18 18:04:54 +02:00

xbzrle.h

migration: Create migration/xbzrle.h

2017-05-18 18:04:54 +02:00