mirror of
https://github.com/mii443/qemu.git
synced 2025-08-22 23:25:48 +00:00
73f6f9a12f
When doing migration using the fd: URI, QEMU will fetch the file descriptor passed in via the monitor at fd_start_outgoing|incoming_migration(), which means the checks at migration_channels_and_transport_compatible() happen too soon and we don't know at that point whether the FD refers to a plain file or a socket. For this reason, we've been allowing a migration channel of type SOCKET_ADDRESS_TYPE_FD to pass the initial verifications in scenarios where the socket migration is not supported, such as with fd + multifd. The commitdecdc76772("migration/multifd: Add mapped-ram support to fd: URI") was supposed to add a second check prior to starting migration to make sure a socket fd is not passed instead of a file fd, but failed to do so. Add the missing verification and update the comment explaining this situation which is currently incorrect. Fixes:decdc76772("migration/multifd: Add mapped-ram support to fd: URI") Signed-off-by: Fabiano Rosas <farosas@suse.de> Reviewed-by: Peter Xu <peterx@redhat.com> Link: https://lore.kernel.org/r/20240315032040.7974-2-farosas@suse.de Signed-off-by: Peter Xu <peterx@redhat.com>
115 lines
2.7 KiB
C
115 lines
2.7 KiB
C
/*
|
|
* QEMU live migration via generic fd
|
|
*
|
|
* Copyright Red Hat, Inc. 2009-2016
|
|
*
|
|
* Authors:
|
|
* Chris Lalancette <clalance@redhat.com>
|
|
* Daniel P. Berrange <berrange@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2. See
|
|
* the COPYING file in the top-level directory.
|
|
*
|
|
* Contributions after 2012-01-13 are licensed under the terms of the
|
|
* GNU GPL, version 2 or (at your option) any later version.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qapi/error.h"
|
|
#include "channel.h"
|
|
#include "fd.h"
|
|
#include "file.h"
|
|
#include "migration.h"
|
|
#include "monitor/monitor.h"
|
|
#include "io/channel-file.h"
|
|
#include "io/channel-socket.h"
|
|
#include "io/channel-util.h"
|
|
#include "options.h"
|
|
#include "trace.h"
|
|
|
|
|
|
static struct FdOutgoingArgs {
|
|
int fd;
|
|
} outgoing_args;
|
|
|
|
int fd_args_get_fd(void)
|
|
{
|
|
return outgoing_args.fd;
|
|
}
|
|
|
|
void fd_cleanup_outgoing_migration(void)
|
|
{
|
|
if (outgoing_args.fd > 0) {
|
|
close(outgoing_args.fd);
|
|
outgoing_args.fd = -1;
|
|
}
|
|
}
|
|
|
|
void fd_start_outgoing_migration(MigrationState *s, const char *fdname, Error **errp)
|
|
{
|
|
QIOChannel *ioc;
|
|
int fd = monitor_get_fd(monitor_cur(), fdname, errp);
|
|
|
|
outgoing_args.fd = -1;
|
|
|
|
if (fd == -1) {
|
|
return;
|
|
}
|
|
|
|
trace_migration_fd_outgoing(fd);
|
|
ioc = qio_channel_new_fd(fd, errp);
|
|
if (!ioc) {
|
|
close(fd);
|
|
return;
|
|
}
|
|
|
|
outgoing_args.fd = fd;
|
|
|
|
qio_channel_set_name(ioc, "migration-fd-outgoing");
|
|
migration_channel_connect(s, ioc, NULL, NULL);
|
|
object_unref(OBJECT(ioc));
|
|
}
|
|
|
|
static gboolean fd_accept_incoming_migration(QIOChannel *ioc,
|
|
GIOCondition condition,
|
|
gpointer opaque)
|
|
{
|
|
migration_channel_process_incoming(ioc);
|
|
object_unref(OBJECT(ioc));
|
|
return G_SOURCE_REMOVE;
|
|
}
|
|
|
|
void fd_start_incoming_migration(const char *fdname, Error **errp)
|
|
{
|
|
QIOChannel *ioc;
|
|
int fd = monitor_fd_param(monitor_cur(), fdname, errp);
|
|
if (fd == -1) {
|
|
return;
|
|
}
|
|
|
|
trace_migration_fd_incoming(fd);
|
|
|
|
ioc = qio_channel_new_fd(fd, errp);
|
|
if (!ioc) {
|
|
close(fd);
|
|
return;
|
|
}
|
|
|
|
if (migrate_multifd()) {
|
|
if (fd_is_socket(fd)) {
|
|
error_setg(errp,
|
|
"Multifd migration to a socket FD is not supported");
|
|
object_unref(ioc);
|
|
return;
|
|
}
|
|
|
|
file_create_incoming_channels(ioc, errp);
|
|
} else {
|
|
qio_channel_set_name(ioc, "migration-fd-incoming");
|
|
qio_channel_add_watch_full(ioc, G_IO_IN,
|
|
fd_accept_incoming_migration,
|
|
NULL, NULL,
|
|
g_main_context_get_thread_default());
|
|
}
|
|
}
|