Ding Hui 2ddafce7f7 vnc: fix resource leak when websocket channel error ...

When we connect to vnc by websocket channel, and disconnect
(maybe by some network exception) before handshake,
qemu will left CLOSE_WAIT socket and never close it

After 04d2529da2 ("ui: convert VNC server to use QIOChannelSocket")
and dd154c4d9f ("io: fix handling of EOF / error conditions in websock GSource"),
the vnc call qio_channel_add_watch only care about G_IO_IN,
but mising G_IO_HUP and G_IO_ERR.
When the websocket channel get EOF or error, it cannot callback,
because the caller ignore the event, that leads to resource leak

We need handle G_IO_HUP and G_IO_ERR event, then cleanup the channel

Fixes: 04d2529da2 ("ui: convert VNC server to use QIOChannelSocket")
Fixes: dd154c4d9f ("io: fix handling of EOF / error conditions in websock GSource")
Cc: qemu-stable@nongnu.org
Signed-off-by: Ding Hui <dinghui@sangfor.com.cn>
Message-id: 20201029032241.11040-1-dinghui@sangfor.com.cn
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

2020-11-04 08:25:17 +01:00

..

icons

configure: move directory options from config-host.mak to meson

2020-10-26 07:08:38 -04:00

keycodemapdb @ 6b3d716e2b

ui: update keycodemapdb to get py3 fixes

2018-02-05 19:53:55 -02:00

shader

meson: clean up build_by_default

2020-09-30 19:09:19 +02:00

cocoa.m

qapi: Restrict 'system wakeup/reset/powerdown' commands to machine.json

2020-10-21 05:00:44 +02:00

console-gl.c

Include qemu-common.h exactly where needed

2019-06-12 13:20:20 +02:00

console.c

ui: Fix default window_id value

2020-10-14 10:20:26 +02:00

curses_keys.h

curses: support wide input

2019-03-11 08:39:02 +01:00

curses.c

curses: Fixes curses compiling errors.

2020-10-14 06:05:56 +02:00

cursor_hidden.xpm

…

cursor_left_ptr.xpm

…

cursor.c

Include qemu-common.h exactly where needed

2019-06-12 13:20:20 +02:00

egl-context.c

Include qemu-common.h exactly where needed

2019-06-12 13:20:20 +02:00

egl-headless.c

ui/egl: fix framebuffer reads

2019-09-17 13:42:02 +02:00

egl-helpers.c

ui/egl: fix framebuffer reads

2019-09-17 13:42:02 +02:00

gtk-egl.c

Include qemu-common.h exactly where needed

2019-06-12 13:20:20 +02:00

gtk-gl-area.c

ui/gtk-gl-area: Plug memleak in gd_gl_area_create_context()

2020-09-04 07:30:57 +02:00

gtk.c

qapi: Restrict 'system wakeup/reset/powerdown' commands to machine.json

2020-10-21 05:00:44 +02:00

input-barrier.c

input-barrier: Register properties as class properties

2020-10-13 15:56:30 -04:00

input-barrier.h

ui: add an embedded Barrier client

2019-09-17 13:43:22 +02:00

input-keymap.c

meson: rename included C source files to .c.inc

2020-08-21 06:18:30 -04:00

input-legacy.c

Clean up inclusion of sysemu/sysemu.h

2019-08-16 13:31:53 +02:00

input-linux.c

Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging

2020-10-15 16:35:06 +01:00

input.c

sysemu: Split sysemu/runstate.h off sysemu/sysemu.h

2019-08-16 13:37:36 +02:00

kbd-state.c

Include qemu/queue.h slightly less

2019-08-16 13:31:52 +02:00

keymaps.c

Clean up inclusion of sysemu/sysemu.h

2019-08-16 13:31:53 +02:00

keymaps.h

Include qemu-common.h exactly where needed

2019-06-12 13:20:20 +02:00

meson.build

configure: move directory options from config-host.mak to meson

2020-10-26 07:08:38 -04:00

qemu-pixman.c

Include qemu-common.h exactly where needed

2019-06-12 13:20:20 +02:00

qemu-x509.h

…

qemu.desktop

ui: fix icon display for GTK frontend under GNOME Shell with Wayland

2019-01-21 09:43:13 +01:00

sdl2-2d.c

Clean up inclusion of sysemu/sysemu.h

2019-08-16 13:31:53 +02:00

sdl2-gl.c

Clean up inclusion of sysemu/sysemu.h

2019-08-16 13:31:53 +02:00

sdl2-input.c

ui/sdl2-input: use trace-events to debug key events

2020-05-19 09:06:44 +02:00

sdl2.c

SDL: enable OpenGL context creation

2020-10-14 06:05:56 +02:00

shader.c

meson: convert ui directory to Meson

2020-08-21 06:30:21 -04:00

spice-app.c

chardev/spice: simplify chardev setup

2020-10-15 11:14:40 +02:00

spice-core.c

spice: wire up monitor in QemuSpiceOps.

2020-10-21 15:46:14 +02:00

spice-display.c

spice: get monitors physical dimension

2020-09-29 10:08:25 +02:00

spice-input.c

spice: move add_interface() to QemuSpiceOps.

2020-10-21 15:46:14 +02:00

spice-module.c

spice: wire up monitor in QemuSpiceOps.

2020-10-21 15:46:14 +02:00

trace-events

trace-events: Fix attribution of trace points to source

2020-09-09 17:17:58 +01:00

trace.h

trace: switch position of headers to what Meson requires

2020-08-21 06:18:24 -04:00

vgafont.h

…

vnc_keysym.h

ui: add next and prior keysyms

2017-07-27 14:23:09 +02:00

vnc-auth-sasl.c

vnc: fix resource leak when websocket channel error

2020-11-04 08:25:17 +01:00

vnc-auth-sasl.h

Include qemu/main-loop.h less

2019-08-16 13:31:52 +02:00

vnc-auth-vencrypt.c

vnc: fix resource leak when websocket channel error

2020-11-04 08:25:17 +01:00

vnc-auth-vencrypt.h

Clean up ill-advised or unusual header guards

2016-07-12 16:20:46 +02:00

vnc-enc-hextile-template.h

ui: vnc: finish removing TABs

2019-02-05 16:50:18 +01:00

vnc-enc-hextile.c

…

vnc-enc-tight.c

vnc: Remove the superfluous break

2020-09-01 08:36:53 +02:00

vnc-enc-tight.h

…

vnc-enc-zlib.c

vnc: fix memory leak when vnc disconnect

2019-09-17 13:45:10 +02:00

vnc-enc-zrle.c

meson: rename included C source files to .c.inc

2020-08-21 06:18:30 -04:00

vnc-enc-zrle.c.inc

meson: rename included C source files to .c.inc

2020-08-21 06:18:30 -04:00

vnc-enc-zrle.h

…

vnc-enc-zywrle-template.c

avoid TABs in files that only contain a few

2019-01-11 15:46:56 +01:00

vnc-enc-zywrle.h

ui: vnc: finish removing TABs

2019-02-05 16:50:18 +01:00

vnc-jobs.c

vnc: fix resource leak when websocket channel error

2020-11-04 08:25:17 +01:00

vnc-jobs.h

ui/vnc: Drop unused vnc_has_job() and vnc_jobs_clear()

2017-02-08 14:59:36 +01:00

vnc-palette.c

…

vnc-palette.h

Include qapi/qmp/qlist.h exactly where needed

2018-02-09 13:52:15 +01:00

vnc-stubs.c

vnc-stubs: Allow -vnc none

2020-10-14 06:05:56 +02:00

vnc-ws.c

vnc: fix resource leak when websocket channel error

2020-11-04 08:25:17 +01:00

vnc-ws.h

Clean up ill-advised or unusual header guards

2016-07-12 16:20:46 +02:00

vnc.c

vnc: fix resource leak when websocket channel error

2020-11-04 08:25:17 +01:00

vnc.h

vnc: drop Error pointer indirection in vnc_client_io_error

2019-12-18 08:36:16 +01:00

win32-kbd-hook.c

ui/win32-kbd-hook: handle AltGr in a hook procedure

2020-05-19 09:06:44 +02:00

x_keymap.c

ui: fix keymap detection under Xwayland

2018-04-10 11:21:54 +02:00

x_keymap.h

ui: convert GTK and SDL1 frontends to keycodemapdb

2018-01-25 15:02:00 +01:00