Markus Armbruster
235e59cf03
qemu-option: Use returned bool to check for failure
The previous commit enables conversion of
foo(..., &err);
if (err) {
...
}
to
if (!foo(..., &err)) {
...
}
for QemuOpts functions that now return true / false on success /
error. Coccinelle script:
@@
identifier fun = {
opts_do_parse, parse_option_bool, parse_option_number,
parse_option_size, qemu_opt_parse, qemu_opt_rename, qemu_opt_set,
qemu_opt_set_bool, qemu_opt_set_number, qemu_opts_absorb_qdict,
qemu_opts_do_parse, qemu_opts_from_qdict_entry, qemu_opts_set,
qemu_opts_validate
};
expression list args, args2;
typedef Error;
Error *err;
@@
- fun(args, &err, args2);
- if (err)
+ if (!fun(args, &err, args2))
{
...
}
A few line breaks tidied up manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-15-armbru@redhat.com>
[Conflict with commit 0b6786a9c1 "block/amend: refactor qcow2 amend
options" resolved by rerunning Coccinelle on master's version]
2020-07-10 15:17:35 +02:00
..
2020-07-02 06:25:28 +02:00
2020-07-02 06:25:29 +02:00
2020-06-15 22:05:28 +02:00
2020-07-10 15:01:06 +02:00
2020-07-06 17:01:11 +02:00
2020-07-10 15:01:06 +02:00
2020-07-10 15:01:06 +02:00
2020-07-10 15:01:06 +02:00
2020-07-10 15:01:06 +02:00
2020-06-15 22:05:28 +02:00
2020-07-10 15:01:06 +02:00
2020-07-02 06:25:29 +02:00
2020-07-03 16:59:45 +01:00
2020-06-15 22:05:28 +02:00
2020-06-26 09:39:40 -04:00
2020-06-26 14:30:28 +01:00
2020-07-09 14:13:19 +01:00
2020-06-23 16:07:07 +02:00
2020-06-26 10:13:52 +01:00
2020-07-10 15:01:06 +02:00
2020-07-10 15:01:06 +02:00
2020-06-15 22:05:28 +02:00
2020-07-06 09:32:47 +02:00
2020-07-10 15:01:06 +02:00
2020-07-10 15:01:06 +02:00
2020-07-10 15:01:06 +02:00
2020-07-10 15:17:35 +02:00
2020-06-15 22:05:28 +02:00
2020-07-03 18:16:01 +02:00
2020-06-15 22:05:28 +02:00
2020-07-02 06:25:29 +02:00
2020-06-15 22:05:28 +02:00
2020-07-10 15:01:06 +02:00
2020-06-15 22:05:28 +02:00
2020-07-10 15:01:06 +02:00
2020-07-10 15:01:06 +02:00
2020-06-15 22:05:28 +02:00
2020-06-22 18:37:12 +02:00
2020-07-10 15:01:06 +02:00
2020-07-10 15:01:06 +02:00
2020-07-10 15:01:06 +02:00
2020-06-10 11:29:44 +02:00
2020-06-22 18:37:12 +02:00
2020-07-10 15:17:35 +02:00
2020-06-15 22:05:28 +02:00
2020-06-23 16:07:07 +02:00
2020-07-03 16:59:44 +01:00
2020-06-22 18:37:12 +02:00
2020-06-19 07:25:55 -04:00
2020-07-10 15:01:06 +02:00
2020-07-02 05:54:59 -04:00
2020-07-10 15:01:06 +02:00
2020-06-23 11:39:47 +01:00
2020-07-02 06:25:29 +02:00
2020-06-23 16:07:07 +02:00
2020-06-22 18:37:12 +02:00
2020-07-07 15:33:59 +02:00