Fan Yang aea18ef938 COLO-compare: Fix incorrect if logic ...

'colo_mark_tcp_pkt' should return 'true' when packets are the same, and
'false' otherwise.  However, it returns 'true' when
'colo_compare_packet_payload' returns non-zero while
'colo_compare_packet_payload' is just a 'memcmp'.  The result is that
COLO-compare reports inconsistent TCP packets when they are actually
the same.

Fixes: f449c9e549 ("colo: compare the packet based on the tcp sequence number")
Cc: qemu-stable@nongnu.org
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Fan Yang <Fan_Yang@sjtu.edu.cn>
Signed-off-by: Jason Wang <jasowang@redhat.com>
(cherry picked from commit 1e907a32b7)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>

2019-11-04 08:25:01 -06:00

..

can

Include qemu/module.h where needed, drop it from qemu-common.h

2019-06-12 13:18:33 +02:00

announce.c

net/announce: Add optional ID

2019-07-02 10:21:06 +08:00

checksum.c

Include qemu-common.h exactly where needed

2019-06-12 13:20:20 +02:00

clients.h

Drop superfluous includes of qapi-types.h and test-qapi-types.h

2018-02-09 05:05:11 +01:00

colo-compare.c

COLO-compare: Fix incorrect if logic

2019-11-04 08:25:01 -06:00

colo-compare.h

colo-compare: use notifier to notify packets comparing result

2018-10-19 11:15:03 +08:00

colo.c

net: do not depend on slirp internals

2019-01-14 00:44:29 +01:00

colo.h

Clean up header guards that don't match their file name

2019-05-13 08:58:55 +02:00

dump.c

Include qemu-common.h exactly where needed

2019-06-12 13:20:20 +02:00

eth.c

Include qemu-common.h exactly where needed

2019-06-12 13:20:20 +02:00

filter-buffer.c

Include qemu-common.h exactly where needed

2019-06-12 13:20:20 +02:00

filter-mirror.c

Include qemu-common.h exactly where needed

2019-06-12 13:20:20 +02:00

filter-replay.c

Include qemu/module.h where needed, drop it from qemu-common.h

2019-06-12 13:18:33 +02:00

filter-rewriter.c

Include qemu-common.h exactly where needed

2019-06-12 13:20:20 +02:00

filter.c

Include qemu/module.h where needed, drop it from qemu-common.h

2019-06-12 13:18:33 +02:00

hub.c

net: hub: suppress warnings of no host network for qtest

2018-12-04 11:06:15 +00:00

hub.h

Include qemu-common.h exactly where needed

2019-06-12 13:20:20 +02:00

l2tpv3.c

Include qemu-common.h exactly where needed

2019-06-12 13:20:20 +02:00

Makefile.objs

build-sys: link with slirp as an external project

2019-03-07 12:46:31 +01:00

net.c

net: remove unused get_str_sep() function

2019-07-02 10:21:06 +08:00

netmap.c

net: netmap: improve netmap_receive_iov()

2019-03-05 11:27:40 +08:00

queue.c

qemu/queue.h: leave head structs anonymous unless necessary

2019-01-11 15:46:55 +01:00

slirp.c

net/slirp: fix the IPv6 prefix length error message

2019-05-17 17:00:12 +08:00

socket.c

net/socket: learn to talk with a unix dgram socket

2019-03-29 15:22:18 +08:00

tap_int.h

Include qemu-common.h exactly where needed

2019-06-12 13:20:20 +02:00

tap-bsd.c

Include qemu-common.h exactly where needed

2019-06-12 13:20:20 +02:00

tap-linux.c

Include qemu-common.h exactly where needed

2019-06-12 13:20:20 +02:00

tap-linux.h

Clean up decorations and whitespace around header guards

2016-07-12 16:20:46 +02:00

tap-solaris.c

qemu-common: Move qemu_isalnum() etc. to qemu/ctype.h

2019-06-11 20:22:09 +02:00

tap-stub.c

net/tap: Replace tap-haiku.c and tap-aix.c by a generic tap-stub.c

2017-05-23 10:10:38 +08:00

tap-win32.c

qapi: Change Netdev into a flat union

2016-07-19 20:18:02 +02:00

tap.c

net: tap: replace snprintf with g_strdup_printf calls

2019-07-29 16:29:30 +08:00

trace-events

net/announce: Add optional ID

2019-07-02 10:21:06 +08:00

util.c

net: Clean up includes

2016-02-04 17:41:30 +00:00

util.h

net: do not depend on slirp internals

2019-01-14 00:44:29 +01:00

vde.c

net/vde: print error on vde_open() failure

2018-03-26 14:52:43 +08:00

vhost-user-stub.c

vhost-net-user: add stubs for when no virtio-net device is present

2019-02-21 12:28:01 -05:00

vhost-user.c

vhost-user: save features if the char dev is closed

2019-11-04 08:09:49 -06:00