Jason Wang c2269a0b54 virtio-net: don't touch virtqueue if vm is stopped ...

Guest state should not be touched if VM is stopped, unfortunately we
didn't check running state and tried to drain tx queue unconditionally
in virtio_net_set_status(). A crash was then noticed as a migration
destination when user type quit after virtqueue state is loaded but
before region cache is initialized. In this case,
virtio_net_drop_tx_queue_data() tries to access the uninitialized
region cache.

Fix this by only dropping tx queue data when vm is running.

Fixes: 283e2c2adc ("net: virtio-net discards TX data after link down")
Cc: Yuri Benditovich <yuri.benditovich@daynix.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: qemu-stable@nongnu.org
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
(cherry picked from commit 70e53e6e4d)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>

2017-12-06 11:40:52 -06:00

..

fsl_etsec

sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE

2017-05-17 10:37:01 -03:00

rocker

net/rocker: Cleanup the useless return value check

2017-06-07 10:58:31 +08:00

allwinner_emac.c

qapi: Change Netdev into a flat union

2016-07-19 20:18:02 +02:00

cadence_gem.c

cadence_gem: Make the revision a property

2017-04-20 17:39:17 +01:00

dp8393x.c

memory: Rename memory_region_init_ram() to memory_region_init_ram_nomigrate()

2017-07-14 17:59:42 +01:00

e1000_regs.h

Clean up header guards that don't match their file name

2016-07-12 16:19:16 +02:00

e1000.c

e1000: disable debug by default

2017-03-31 08:48:13 +08:00

e1000e_core.c

e1000e: Fix ICR "Other" causes clear logic

2017-05-23 10:10:38 +08:00

e1000e_core.h

e1000e: Flush all receive queues on receive enable

2016-09-27 17:54:22 +08:00

e1000e.c

pci: Make errp the last parameter of pci_add_capability()

2017-07-03 22:29:49 +03:00

e1000x_common.c

hw/net/e1000: Don't use *_to_cpup()

2016-06-27 16:39:56 +01:00

e1000x_common.h

e1000: Move out code that will be reused in e1000e

2016-06-02 10:42:29 +08:00

eepro100.c

pci: Make errp the last parameter of pci_add_capability()

2017-07-03 22:29:49 +03:00

etraxfs_eth.c

qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable

2017-05-17 10:37:00 -03:00

ftgmac100.c

net/ftgmac100: add a 'aspeed' property

2017-04-25 19:17:25 +08:00

imx_fec.c

net: imx: limit buffer descriptor count

2017-02-15 11:18:57 +08:00

lan9118.c

hw/ptimer: Introduce timer policy feature

2016-09-22 18:13:06 +01:00

lance.c

qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable

2017-05-17 10:37:00 -03:00

Makefile.objs

net: add FTGMAC100 support

2017-04-24 11:30:03 +08:00

mcf_fec.c

hw/net: implement MIB counters in mcf_fec driver

2017-03-14 15:39:55 +08:00

milkymist-minimac2.c

memory: Rename memory_region_init_ram() to memory_region_init_ram_nomigrate()

2017-07-14 17:59:42 +01:00

mipsnet.c

qapi: Change Netdev into a flat union

2016-07-19 20:18:02 +02:00

ne2000-isa.c

qapi: Change Netdev into a flat union

2016-07-19 20:18:02 +02:00

ne2000.c

qapi: Change Netdev into a flat union

2016-07-19 20:18:02 +02:00

ne2000.h

Clean up decorations and whitespace around header guards

2016-07-12 16:20:46 +02:00

net_rx_pkt.c

NetRxPkt: Remove code duplication in net_rx_pkt_pull_data()

2017-03-06 11:46:02 +08:00

net_rx_pkt.h

net_pkt: Extend packet abstraction as required by e1000e functionality

2016-06-02 10:42:28 +08:00

net_tx_pkt.c

net: vmxnet: use g_new for pkt initialisation

2016-08-18 12:05:18 +08:00

net_tx_pkt.h

clean-includes: run it once more

2016-06-16 18:39:03 +02:00

opencores_eth.c

qapi: Change Netdev into a flat union

2016-07-19 20:18:02 +02:00

pcnet-pci.c

qapi: Change Netdev into a flat union

2016-07-19 20:18:02 +02:00

pcnet.c

net: pcnet: fix source formatting and indentation

2016-10-26 09:57:59 +08:00

pcnet.h

Clean up decorations and whitespace around header guards

2016-07-12 16:20:46 +02:00

rtl8139.c

rtl8139: correctly handle PHY reset

2017-01-06 10:38:05 +08:00

smc91c111.c

qapi: Change Netdev into a flat union

2016-07-19 20:18:02 +02:00

spapr_llan.c

hw/net/spapr_llan: 6 byte mac address device tree entry

2017-02-22 14:28:53 +11:00

stellaris_enet.c

arm: stellaris: make MII accesses complete immediately

2017-01-27 15:29:08 +00:00

trace-events

trace-events: fix code style: print 0x before hex numbers

2017-08-01 12:13:07 +01:00

vhost_net.c

spec/vhost-user spec: Add IOMMU support

2017-06-02 18:57:17 +03:00

virtio-net.c

virtio-net: don't touch virtqueue if vm is stopped

2017-12-06 11:40:52 -06:00

vmware_utils.h

vmxnet3: Fix reading/writing guest memory specially when behind an IOMMU

2016-06-28 10:13:57 +08:00

vmxnet3.c

migration: Split registration functions from vmstate.h

2017-06-13 11:00:44 +02:00

vmxnet3.h

Clean up ill-advised or unusual header guards

2016-07-12 16:20:46 +02:00

vmxnet_debug.h

Clean up ill-advised or unusual header guards

2016-07-12 16:20:46 +02:00

xen_nic.c

xen: Rename xen_be_send_notify

2016-10-28 17:54:21 -07:00

xgmac.c

Remove/replace sysemu/char.h inclusion

2017-06-02 11:33:52 +04:00

xilinx_axienet.c

xilinx: Fix latent error handling bug

2017-07-13 13:45:53 +02:00

xilinx_ethlite.c

hw/net: Fix a heap overflow in xlnx.xps-ethernetlite

2016-08-09 15:27:18 +08:00