Markus Armbruster 02835d5744 vnc: Fix tight_detect_smooth_image() for lossless case ...

VncTight member uint8_t quality is either (uint8_t)-1 for lossless or
less than 10 for lossy.

tight_detect_smooth_image() first promotes it to int, then compares
with -1.  Always unequal, so we always execute the lossy code.  Reads
beyond tight_conf[] and returns crap when quality is actually
lossless.

Compare to (uint8_t)-1 instead, like we do elsewhere.

Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
(cherry picked from commit 2e7bcdb99a)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>

2014-07-15 19:28:02 -05:00

..

cocoa.m

cocoa: Avoid deprecated NSOpenPanel beginSheetForDirectory

2013-05-29 01:28:31 +02:00

console.c

console: Remove unused debug code

2013-11-13 16:02:28 +04:00

curses_keys.h

janitor: add guards to headers

2012-12-19 08:31:31 +01:00

curses.c

curses: fixup SIGWINCH handler mess

2013-11-25 20:36:27 -08:00

cursor_hidden.xpm

ui: move files to ui/ and include/ui/

2012-12-19 08:31:30 +01:00

cursor_left_ptr.xpm

ui: move files to ui/ and include/ui/

2012-12-19 08:31:30 +01:00

cursor.c

ui: move files to ui/ and include/ui/

2012-12-19 08:31:30 +01:00

d3des.c

…

d3des.h

janitor: add guards to headers

2012-12-19 08:31:31 +01:00

gtk.c

gtk: Remove unused include statements which are not portable

2013-08-27 14:21:16 +02:00

input.c

aio / timers: Switch entire codebase to the new timer API

2013-08-22 19:14:24 +02:00

keymaps.c

qemu-char: add support for U-prefixed symbols

2013-11-13 15:48:38 +04:00

keymaps.h

…

Makefile.objs

ui/Makefile.objs: delete unnecessary cocoa.o dependency

2013-10-16 18:21:01 +02:00

qemu-pixman.c

pixman: render vgafont glyphs into pixman images

2013-04-16 09:03:47 +02:00

qemu-x509.h

ui: move files to ui/ and include/ui/

2012-12-19 08:31:30 +01:00

sdl_keysym.h

…

sdl_zoom_template.h

sdl: Fix heap smash in sdl_zoom_rgb{16,32} for int > 32 bits

2013-01-15 18:25:30 -06:00

sdl_zoom.c

sdl: Fix heap smash in sdl_zoom_rgb{16,32} for int > 32 bits

2013-01-15 18:25:30 -06:00

sdl_zoom.h

…

sdl.c

sdl: Reverse support for video mode setting

2013-11-06 21:47:13 -08:00

spice-core.c

spice: fix multihead support

2013-10-17 12:42:54 +02:00

spice-display.c

spice: fix multihead support

2013-10-17 12:42:54 +02:00

spice-input.c

ui: move files to ui/ and include/ui/

2012-12-19 08:31:30 +01:00

vgafont.h

ui: move files to ui/ and include/ui/

2012-12-19 08:31:30 +01:00

vnc_keysym.h

qemu-char: add missing characters used in keymaps

2013-11-13 15:48:38 +04:00

vnc-auth-sasl.c

Merge branch 'trivial-patches' of git://github.com/stefanha/qemu

2012-10-06 18:54:14 +02:00

vnc-auth-sasl.h

aio / timers: Untangle include files

2013-08-22 19:10:27 +02:00

vnc-auth-vencrypt.c

aio / timers: Untangle include files

2013-08-22 19:10:27 +02:00

vnc-auth-vencrypt.h

…

vnc-enc-hextile-template.h

pixman/vnc: use pixman images in vnc.

2012-11-01 14:00:04 +01:00

vnc-enc-hextile.c

pixman/vnc: remove dead code.

2012-11-01 14:00:05 +01:00

vnc-enc-tight.c

vnc: Fix tight_detect_smooth_image() for lossless case

2014-07-15 19:28:02 -05:00

vnc-enc-tight.h

…

vnc-enc-zlib.c

…

vnc-enc-zrle-template.c

…

vnc-enc-zrle.c

pixman/vnc: use pixman images in vnc.

2012-11-01 14:00:04 +01:00

vnc-enc-zrle.h

…

vnc-enc-zywrle-template.c

…

vnc-enc-zywrle.h

misc: Spelling and grammar fixes in comments

2013-10-26 13:06:45 +04:00

vnc-jobs.c

vnc: stop using DisplayState

2013-03-18 10:21:58 +01:00

vnc-jobs.h

vnc: add missing static

2012-11-01 19:49:45 +01:00

vnc-palette.c

ui/vnc-palette.c: Include headers it needs

2012-12-06 09:17:05 +01:00

vnc-palette.h

misc: move include files to include/qemu/

2012-12-19 08:32:39 +01:00

vnc-tls.c

TLS support for VNC Websockets

2013-05-03 12:04:57 -05:00

vnc-tls.h

misc: move include files to include/qemu/

2012-12-19 08:32:39 +01:00

vnc-ws.c

aio / timers: Untangle include files

2013-08-22 19:10:27 +02:00

vnc-ws.h

TLS support for VNC Websockets

2013-05-03 12:04:57 -05:00

vnc.c

vnc: use booleans for vnc_connect, vnc_listen_read and vnc_display_add_client

2013-06-21 22:52:50 +04:00

vnc.h

TLS support for VNC Websockets

2013-05-03 12:04:57 -05:00

x_keymap.c

…

x_keymap.h

…