defb70980f
hw/acpi/erst.c: Fix memory handling issues
...
- Fix memset argument order: The second argument is
the value, the length goes last.
- Fix an integer overflow reported by Alexander Bulekov.
Both issues allow the guest to overrun the host buffer
allocated for the ERST memory device.
Cc: Eric DeVolder <eric.devolder@oracle.com
Cc: Alexander Bulekov <alxndr@bu.edu >
Cc: qemu-stable@nongnu.org
Fixes: f7e26ffa59alxndr@bu.edu >
Signed-off-by: Christian A. Ehrhardt <lk@c--e.de >
Message-Id: <20221024154233.1043347-1-lk@c--e.de >
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1268
Reviewed-by: Alexander Bulekov <alxndr@bu.edu >
Reviewed-by: Eric DeVolder <eric.devolder@oracle.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2022-11-07 14:08:17 -05:00
8c97e4deec
acpi/erst: fix fallthrough code upon validation failure
...
At any step when any validation fail in check_erst_backend_storage(), there is
no need to continue further through other validation checks. Further, by
continuing even when record_size is 0, we run the risk of triggering a divide
by zero error if we continued with other validation checks. Hence, we should
simply return from this function upon validation failure.
CC: Peter Maydell <peter.maydell@linaro.org >
CC: Eric DeVolder <eric.devolder@oracle.com >
Signed-off-by: Ani Sinha <ani@anisinha.ca >
Message-Id: <20220513141005.1929422-1-ani@anisinha.ca >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Reviewed-by: Eric DeVolder <eric.devolder@oracle.com >
2022-06-16 12:54:58 -04:00
f8bdfbdba9
hw/acpi/erst: clean up unused IS_UEFI_CPER_RECORD macro
...
This change is cosmetic. IS_UEFI_CPER_RECORD macro definition that was added
as a part of the ERST implementation seems to be unused. Remove it.
CC: Eric DeVolder <eric.devolder@oracle.com >
Reviewed-by: Eric DeVolder <eric.devolder@oracle.com >
Signed-off-by: Ani Sinha <ani@anisinha.ca >
Message-Id: <20220223143322.927136-5-ani@anisinha.ca >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2022-03-04 08:30:52 -05:00
c9cd06ca00
ACPI ERST: build the ACPI ERST table
...
This builds the ACPI ERST table to inform OSPM how to communicate
with the acpi-erst device.
Signed-off-by: Eric DeVolder <eric.devolder@oracle.com >
Reviewed-by: Ani Sinha <ani@anisinha.ca >
Message-Id: <1643402289-22216-7-git-send-email-eric.devolder@oracle.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2022-02-06 04:33:50 -05:00
f7e26ffa59
ACPI ERST: support for ACPI ERST feature
...
This implements a PCI device for ACPI ERST. This implements the
non-NVRAM "mode" of operation for ERST as it is supported by
Linux and Windows.
Signed-off-by: Eric DeVolder <eric.devolder@oracle.com >
Reviewed-by: Ani Sinha <ani@anisinha.ca >
Message-Id: <1643402289-22216-6-git-send-email-eric.devolder@oracle.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2022-02-06 04:33:50 -05:00
