aafd758410
util: Clean up includes
...
Clean up includes so that osdep.h is included first and headers
which it implies are not included manually.
This commit was created with scripts/clean-includes.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org >
Message-id: 1454089805-5470-6-git-send-email-peter.maydell@linaro.org
2016-02-04 17:01:04 +00:00
2b21233061
util/uri: Add overflow check to rfc3986_parse_port
...
And while at it, replace tabs by eight spaces in this function.
Signed-off-by: Max Reitz <mreitz@redhat.com >
Message-Id: <1424887718-10800-2-git-send-email-mreitz@redhat.com >
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2015-03-18 12:05:31 +01:00
afb30dde3a
util/uri: URI member path can be null, compare more carfully
...
uri_resolve_relative() calls strcmp(bas->path, ref->path). However,
either argument could be null! Evidence: the code checks for null
after the comparison. Spotted by Coverity.
I suspect this was screwed up when we stole the code from libxml2.
There the conditional reads
xmlStrEqual((xmlChar *)bas->path, (xmlChar *)ref->path)
with
int
xmlStrEqual(const xmlChar *str1, const xmlChar *str2) {
if (str1 == str2) return(1);
if (str1 == NULL) return(0);
if (str2 == NULL) return(0);
do {
if (*str1++ != *str2) return(0);
} while (*str2++);
return(1);
}
Fix by replicating libxml2's logic faithfully.
Cc: Paolo Bonzini <pbonzini@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru >
2015-02-10 09:27:20 +03:00
afd5ea3671
util/uri: realloc2n() can't fail, drop dead error handling
...
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru >
2015-02-10 09:27:20 +03:00
c89c6e80a6
util/uri: uri_new() can't fail, drop dead error handling
...
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru >
2015-02-10 09:27:20 +03:00
9be71be5bd
util: Fuse g_malloc(); memset() into g_new0()
...
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
Reviewed-by: Fam Zheng <famz@redhat.com >
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru >
2014-12-10 11:33:38 +03:00
44c2286b5d
util: Drop superfluous conditionals around g_free()
...
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
Reviewed-by: Fam Zheng <famz@redhat.com >
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru >
2014-12-10 11:32:37 +03:00
24588100ab
Drop superfluous conditionals around g_strdup()
...
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Fam Zheng <famz@redhat.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru >
2014-12-10 11:30:55 +03:00
7f303adc4f
clean unnecessary code: don't check g_strdup arg for NULL
...
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com >
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru >
2013-05-12 13:25:55 +04:00
baacf04799
build: move libqemuutil.a components to util/
...
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2013-01-12 18:42:50 +01:00
