95fad99cb2
hw/audio/fmopl: fix segmentation fault
...
Current code allocates the memory for ENV_CURVE too late. Move
allocation to OPLOpenTable() and deallocation to OPLCloseTable().
To reproduce the bug start qemu with -soundhw adlib.
Fixes 2eea51bd01vr_qemu@t-online.de >
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com >
Message-id: 20200324061855.5951-1-vr_qemu@t-online.de
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2020-03-25 09:55:40 +01:00
2eea51bd01
hw/audio/fmopl: Move ENV_CURVE to .heap to save 32KiB of .bss
...
This buffer is only used by the adlib audio device. Move it to
the .heap to release 32KiB of .bss (size reported on x86_64 host).
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com >
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com >
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2020-03-16 23:02:24 +01:00
02f7a1644d
hw/audio/fmopl: Fix a typo twice
...
Reviewed-by: Laurent Vivier <laurent@vivier.eu >
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com >
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com >
Message-Id: <20200305124525.14555-2-philmd@redhat.com >
Signed-off-by: Laurent Vivier <laurent@vivier.eu >
2020-03-09 15:59:31 +01:00
e9808d0969
hw: use "qemu/osdep.h" as first #include in source files
...
applied using ./scripts/clean-includes
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org >
Reviewed-by: Peter Maydell <peter.maydell@linaro.org >
Acked-by: David Gibson <david@gibson.dropbear.id.au >
Acked-by: Cornelia Huck <cohuck@redhat.com >
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru >
2017-12-18 17:07:02 +03:00
c57fbf50e7
audio/fmopl: modify timer callback to give opaque and channel parameters in two arguments
...
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org >
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org >
Message-id: 20170621043401.19842-2-hpoussin@reactos.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2017-07-17 11:09:02 +02:00
9ea5ada76f
audio: Use ARRAY_SIZE from qemu/osdep.h
...
Signed-off-by: Juan Quintela <quintela@redhat.com >
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org >
Message-id: 20170425223739.6703-27-quintela@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2017-05-04 09:16:05 +02:00
d52ccc0eca
audio: un-export OPLResetChip
...
Signed-off-by: Juan Quintela <quintela@redhat.com >
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org >
Message-id: 20170425223739.6703-26-quintela@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2017-05-04 09:16:05 +02:00
b3b40917c7
audio: UpdateHandler is not used anymore
...
Signed-off-by: Juan Quintela <quintela@redhat.com >
Message-id: 20170425223739.6703-24-quintela@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2017-05-04 09:16:05 +02:00
e14e09c945
audio: IRQHandler is not used anymore
...
Signed-off-by: Juan Quintela <quintela@redhat.com >
Message-id: 20170425223739.6703-23-quintela@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2017-05-04 09:16:05 +02:00
ade339896b
audio: OPLSetUpdateHandler is not used anywhere
...
Signed-off-by: Juan Quintela <quintela@redhat.com >
Message-id: 20170425223739.6703-22-quintela@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2017-05-04 09:16:05 +02:00
17a1694a56
audio: OPLSetIRQHandler is not used anywhere
...
Signed-off-by: Juan Quintela <quintela@redhat.com >
Message-id: 20170425223739.6703-21-quintela@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2017-05-04 09:16:05 +02:00
8f7e2c2cb7
audio: Remove type field
...
It was not used anymore as now there is only one type of devices.
Signed-off-by: Juan Quintela <quintela@redhat.com >
Message-id: 20170425223739.6703-14-quintela@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2017-05-04 09:16:04 +02:00
7852b53acc
audio: Remove Unused OPL_TYPE_*
...
Since we removed the previous unused devices, they are not used anymore.
Signed-off-by: Juan Quintela <quintela@redhat.com >
Message-id: 20170425223739.6703-13-quintela@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2017-05-04 09:16:04 +02:00
8ec734d027
audio: Unfold OPLSAMPLE
...
It was used only once, and now it was always int16_t.
Signed-off-by: Juan Quintela <quintela@redhat.com >
Message-id: 20170425223739.6703-12-quintela@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2017-05-04 09:16:04 +02:00
7f643fb53a
audio: Remove INT32
...
Signed-off-by: Juan Quintela <quintela@redhat.com >
Message-id: 20170425223739.6703-11-quintela@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2017-05-04 09:16:04 +02:00
7bf10b1de2
audio: remove INT16
...
Signed-off-by: Juan Quintela <quintela@redhat.com >
Message-id: 20170425223739.6703-10-quintela@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2017-05-04 09:16:04 +02:00
3795f18095
audio: remove UINT32
...
Signed-off-by: Juan Quintela <quintela@redhat.com >
Message-id: 20170425223739.6703-8-quintela@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2017-05-04 09:16:03 +02:00
4a796e979e
audio: Remove UINT8
...
uint8_t has existed since ..... all this century?
Signed-off-by: Juan Quintela <quintela@redhat.com >
Message-id: 20170425223739.6703-6-quintela@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2017-05-04 09:16:03 +02:00
882ab9d615
audio: YM3812 was always defined
...
So, remove the ifdefs.
Signed-off-by: Juan Quintela <quintela@redhat.com >
Message-id: 20170425223739.6703-5-quintela@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2017-05-04 09:16:03 +02:00
2004429e9b
audio: Remove YM3526 support
...
It was never compiled in.
Signed-off-by: Juan Quintela <quintela@redhat.com >
Message-id: 20170425223739.6703-4-quintela@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2017-05-04 09:16:03 +02:00
b6c6919e21
audio: remove Y8950 configuration
...
Include file has never been on qemu and it has been undefined from the very beginning.
Signed-off-by: Juan Quintela <quintela@redhat.com >
Message-id: 20170425223739.6703-3-quintela@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2017-05-04 09:16:03 +02:00
6086a565b0
audio: Clean up includes
...
Clean up includes so that osdep.h is included first and headers
which it implies are not included manually.
This commit was created with scripts/clean-includes.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org >
Message-id: 1453138432-8324-1-git-send-email-peter.maydell@linaro.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2016-02-02 13:57:31 +01:00
67cc32ebfd
typofixes - v4
...
Signed-off-by: Veres Lajos <vlajos@gmail.com >
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru >
2015-09-11 10:45:43 +03:00
37f6be977a
audio: fmopl: drop INLINE macro
...
This commit expands all uses of the INLINE macro and drop it.
The reason for this is to avoid clashes with external libraries with
bad name conventions and also because renaming keywords is not a good
practice.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com >
2014-06-23 11:01:24 -04:00
69df1c3c9d
audio: Add 'static' attributes to several variables
...
Signed-off-by: Stefan Weil <sw@weilnetz.de >
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru >
2014-03-15 13:54:18 +04:00
47b43a1f41
hw: move private headers to hw/ subdirectories.
...
Many headers are used only in a single directory. These can be
kept in hw/.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2013-04-08 18:13:16 +02:00
49ab747f66
hw: move target-independent files to subdirectories
...
This patch tackles all files that are compiled once, moving
them to subdirectories of hw/.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2013-04-08 18:13:12 +02:00
