5f7655f6ef
virtio-rng: Keep the default backend out of VirtIORNGConf
...
The default backend is only used within virtio_rng_device_realize().
Replace VirtIORNGConf member default_backend by a local variable.
Adjust its type to reduce conversions.
While there, pass &error_abort instead of NULL when failure would be a
programming error.
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Signed-off-by: Laurent Vivier <lvivier@redhat.com >
Message-Id: <20190820160615.14616-3-lvivier@redhat.com >
2019-09-04 06:32:51 -04:00
ec150c7e09
include: Make headers more self-contained
...
Back in 2016, we discussed[1] rules for headers, and these were
generally liked:
1. Have a carefully curated header that's included everywhere first. We
got that already thanks to Peter: osdep.h.
2. Headers should normally include everything they need beyond osdep.h.
If exceptions are needed for some reason, they must be documented in
the header. If all that's needed from a header is typedefs, put
those into qemu/typedefs.h instead of including the header.
3. Cyclic inclusion is forbidden.
This patch gets include/ closer to obeying 2.
It's actually extracted from my "[RFC] Baby steps towards saner
headers" series[2], which demonstrates a possible path towards
checking 2 automatically. It passes the RFC test there.
[1] Message-ID: <87h9g8j57d.fsf@blackfin.pond.sub.org >
https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
[2] Message-Id: <20190711122827.18970-1-armbru@redhat.com >
https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg02715.html
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Alistair Francis <alistair.francis@wdc.com >
Message-Id: <20190812052359.30071-2-armbru@redhat.com >
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com >
2019-08-16 13:31:51 +02:00
a23a6d1839
virtio-rng: stop virtqueue while the CPU is stopped
...
If we modify the virtio-rng virqueue while the
vmstate is already migrated we can have some
inconsistencies between the virtqueue state and
the memory content.
To avoid this, stop the virtqueue while the CPU
is stopped.
Signed-off-by: Laurent Vivier <lvivier@redhat.com >
Reviewed-by: Amit Shah <amit@kernel.org >
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com >
Reviewed-by: Juan Quintela <quintela@redhat.com >
Signed-off-by: Juan Quintela <quintela@redhat.com >
2017-04-21 12:25:40 +02:00
2a6a4076e1
Clean up ill-advised or unusual header guards
...
Cleaned up with scripts/clean-header-guards.pl.
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Richard Henderson <rth@twiddle.net >
2016-07-12 16:20:46 +02:00
cde6361534
rng-random: rename RndRandom to RngRandom
...
Usually, Random Number Generator is abbreviated to RNG/rng.
so replacing RndRandom with RngRandom seems more reasonable
and keep consistent with RngBackend.
Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com >
Reviewed-by: Pankaj Gupta <pagupta@redhat.com >
Message-Id: <1460684168-5403-1-git-send-email-weijg.fnst@cn.fujitsu.com >
Signed-off-by: Amit Shah <amit.shah@redhat.com >
2016-05-23 12:18:43 +05:30
621a20e081
virtio-rng: trigger timer only when guest requests for entropy
...
This patch triggers timer only when guest requests for
entropy. As soon as first request from guest for entropy
comes we set the timer. Timer bumps up the quota value
when it gets triggered.
Signed-off-by: Pankaj Gupta <pagupta@redhat.com >
Reviewed-by: Amit Shah <amit.shah@redhat.com >
Message-Id: <1436962608-9961-2-git-send-email-pagupta@redhat.com >
[Re-worded patch subject, removed extra whitespace -- Amit]
Signed-off-by: Amit Shah <amit.shah@redhat.com >
2015-07-17 19:05:16 +05:30
fe704809b9
virtio-rng: move qdev properties into virtio-rng.c
...
As only one place in virtio-rng.c uses DEFINE_VIRTIO_RNG_PROPERTIES,
there is no need to expose it. Inline it into virtio-rng.c to avoid
wrongly use.
Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com >
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org >
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com >
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2015-06-10 18:15:34 +02:00
3e96b2db08
virtio-rng: use standard-headers
...
Drop duplicated code.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
Reviewed-by: Thomas Huth <thuth@linux.vnet.ibm.com >
2015-02-26 13:04:04 +01:00
a8d57dfb28
virtio-rng: Convert to QOM realize
...
Signed-off-by: Andreas Färber <afaerber@suse.de >
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2013-12-09 21:46:49 +01:00
611aa333b4
virtio-rng: cleanup: use QOM casts.
...
As the virtio-rng-pci, virtio-rng-s390 and virtio-rng-ccw are
switched to the new API, we can use QOM casts.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com >
Reviewed-by: Andreas Färber <afaerber@suse.de >
Reviewed-by: Andreas Färber <afaerber@suse.de >
Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com >
Acked-by: Amit Shah <amit.shah@redhat.com >
Message-id: 1366790881-3026-9-git-send-email-fred.konrad@greensocs.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com >
2013-04-24 11:50:20 -05:00
65f3b678f5
virtio-rng: cleanup: remove qdev field.
...
The qdev field is no longer needed, just drop it.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com >
Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com >
Acked-by: Amit Shah <amit.shah@redhat.com >
Message-id: 1366790881-3026-8-git-send-email-fred.konrad@greensocs.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com >
2013-04-24 11:50:19 -05:00
6eac8aec02
virtio-rng: add virtio-rng device.
...
Create virtio-rng-device which extends virtio-device, so it can be connected on
virtio-bus.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com >
Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com >
Acked-by: Amit Shah <amit.shah@redhat.com >
Message-id: 1366790881-3026-3-git-send-email-fred.konrad@greensocs.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com >
2013-04-24 11:50:19 -05:00
af1a8ad646
virtio-rng: don't use pointer for configuration.
...
The configuration field must not be a pointer as it will be used for
virtio-rng properties. So *conf is replaced by conf.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com >
Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com >
Acked-by: Amit Shah <amit.shah@redhat.com >
Message-id: 1366790881-3026-2-git-send-email-fred.konrad@greensocs.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com >
2013-04-24 11:50:19 -05:00
dccfcd0e5f
sysemu: avoid proliferation of include/ subdirectories
...
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2013-04-15 18:19:25 +02:00
0d09e41a51
hw: move headers to include/
...
Many of these should be cleaned up with proper qdev-/QOM-ification.
Right now there are many catch-all headers in include/hw/ARCH depending
on cpu.h, and this makes it necessary to compile these files per-target.
However, fixing this does not belong in these patches.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2013-04-08 18:13:10 +02:00
