e5ef4ec28b
disas: include an optional note for the start of disassembly
...
This will become useful shortly for providing more information about
output assembly inline. While there fix up the indenting and code
formatting in disas().
Signed-off-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com >
Message-Id: <20200513175134.19619-9-alex.bennee@linaro.org >
2020-05-15 15:25:16 +01:00
cbafa2362a
plugin: add qemu_plugin_insn_disas helper
...
Give the plugins access to the QEMU dissasembler so they don't have to
re-invent the wheel. We generate a warning when there are spare bytes
in the decode buffer. This is usually due to the front end loading in
more bytes than decoded.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
2019-10-28 15:12:38 +00:00
ec150c7e09
include: Make headers more self-contained
...
Back in 2016, we discussed[1] rules for headers, and these were
generally liked:
1. Have a carefully curated header that's included everywhere first. We
got that already thanks to Peter: osdep.h.
2. Headers should normally include everything they need beyond osdep.h.
If exceptions are needed for some reason, they must be documented in
the header. If all that's needed from a header is typedefs, put
those into qemu/typedefs.h instead of including the header.
3. Cyclic inclusion is forbidden.
This patch gets include/ closer to obeying 2.
It's actually extracted from my "[RFC] Baby steps towards saner
headers" series[2], which demonstrates a possible path towards
checking 2 automatically. It passes the RFC test there.
[1] Message-ID: <87h9g8j57d.fsf@blackfin.pond.sub.org >
https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
[2] Message-Id: <20190711122827.18970-1-armbru@redhat.com >
https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg02715.html
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Alistair Francis <alistair.francis@wdc.com >
Message-Id: <20190812052359.30071-2-armbru@redhat.com >
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com >
2019-08-16 13:31:51 +02:00
a8d2532645
Include qemu-common.h exactly where needed
...
No header includes qemu-common.h after this commit, as prescribed by
qemu-common.h's file comment.
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20190523143508.25387-5-armbru@redhat.com >
[Rebased with conflicts resolved automatically, except for
include/hw/arm/xlnx-zynqmp.h hw/arm/nrf51_soc.c hw/arm/msf2-soc.c
block/qcow2-refcount.c block/qcow2-cluster.c block/qcow2-cache.c
target/arm/cpu.h target/lm32/cpu.h target/m68k/cpu.h target/mips/cpu.h
target/moxie/cpu.h target/nios2/cpu.h target/openrisc/cpu.h
target/riscv/cpu.h target/tilegx/cpu.h target/tricore/cpu.h
target/unicore32/cpu.h target/xtensa/cpu.h; bsd-user/main.c and
net/tap-bsd.c fixed up]
2019-06-12 13:20:20 +02:00
1d48474d8e
disas: Remove unused flags arguments
...
Now that every target is using the disas_set_info hook,
the flags argument is unused. Remove it.
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org >
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org >
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
2017-10-25 11:55:09 +02:00
2a6a4076e1
Clean up ill-advised or unusual header guards
...
Cleaned up with scripts/clean-header-guards.pl.
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Richard Henderson <rth@twiddle.net >
2016-07-12 16:20:46 +02:00
33c11879fd
qemu-common: push cpu.h inclusion out of qemu-common.h
...
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2016-05-19 16:42:29 +02:00
d49190c420
disas: Remove uses of CPU env
...
disas does not need to access the CPU env for any reason. Change the
APIs to accept CPU pointers instead. Small change pattern needs to be
applied to all target translate.c. This brings us closer to making
disas.o a common-obj and less architecture specific in general.
Cc: Richard Henderson <rth@twiddle.net >
Cc: Peter Maydell <peter.maydell@linaro.org >
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com >
Cc: Paolo Bonzini <pbonzini@redhat.com >
Cc: Eduardo Habkost <ehabkost@redhat.com >
Cc: Michael Walle <michael@walle.cc >
Cc: Aurelien Jarno <aurelien@aurel32.net >
Cc: Leon Alrae <leon.alrae@imgtec.com >
Cc: Jia Liu <proljc@gmail.com >
Cc: Alexander Graf <agraf@suse.de >
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk >
Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de >
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn >
Cc: Max Filippov <jcmvbkbc@gmail.com >
Reviewed-by: Richard Henderson <rth@twiddle.net >
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com >
Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com >
Acked-by: Luiz Capitulino <lcapitulino@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2015-06-22 17:40:01 +02:00
76cad71136
build: kill libdis, move disassemblers to disas/
...
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2012-12-19 08:29:06 +01:00
