51654aa52a
iscsi: add missing colons to the qapi docs
...
The missing colons make the iscsi part of the documentation not render
quite as nicely, so add those in.
Signed-off-by: Jeff Cody <jcody@redhat.com >
2017-02-27 23:33:41 -05:00
d7941f4eed
Merge remote-tracking branch 'remotes/armbru/tags/pull-util-2017-02-23' into staging
...
option cutils: Fix and clean up number conversions
# gpg: Signature made Thu 23 Feb 2017 19:41:17 GMT
# gpg: using RSA key 0x3870B400EB918653
# gpg: Good signature from "Markus Armbruster <armbru@redhat.com >"
# gpg: aka "Markus Armbruster <armbru@pond.sub.org >"
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867 4E5F 3870 B400 EB91 8653
* remotes/armbru/tags/pull-util-2017-02-23: (24 commits)
option: Fix checking of sizes for overflow and trailing crap
util/cutils: Change qemu_strtosz*() from int64_t to uint64_t
util/cutils: Return qemu_strtosz*() error and value separately
util/cutils: Let qemu_strtosz*() optionally reject trailing crap
qemu-img: Wrap cvtnum() around qemu_strtosz()
test-cutils: Drop suffix from test_qemu_strtosz_simple()
test-cutils: Use qemu_strtosz() more often
util/cutils: Drop QEMU_STRTOSZ_DEFSUFFIX_* macros
util/cutils: New qemu_strtosz()
util/cutils: Rename qemu_strtosz() to qemu_strtosz_MiB()
util/cutils: New qemu_strtosz_metric()
test-cutils: Cover qemu_strtosz() around range limits
test-cutils: Cover qemu_strtosz() with trailing crap
test-cutils: Cover qemu_strtosz() invalid input
test-cutils: Add missing qemu_strtosz()... endptr checks
option: Fix to reject invalid and overflowing numbers
util/cutils: Clean up control flow around qemu_strtol() a bit
util/cutils: Clean up variable names around qemu_strtol()
util/cutils: Rename qemu_strtoll(), qemu_strtoull()
util/cutils: Rewrite documentation of qemu_strtol() & friends
...
Signed-off-by: Peter Maydell <peter.maydell@linaro.org >
2017-02-24 18:34:27 +00:00
f46bfdbfc8
util/cutils: Change qemu_strtosz*() from int64_t to uint64_t
...
This will permit its use in parse_option_size().
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com >
Cc: Eduardo Habkost <ehabkost@redhat.com > (maintainer:X86)
Cc: Kevin Wolf <kwolf@redhat.com > (supporter:Block layer core)
Cc: Max Reitz <mreitz@redhat.com > (supporter:Block layer core)
Cc: qemu-block@nongnu.org (open list:Block layer core)
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com >
Message-Id: <1487708048-2131-24-git-send-email-armbru@redhat.com >
2017-02-23 20:35:36 +01:00
f17fd4fdf0
util/cutils: Return qemu_strtosz*() error and value separately
...
This makes qemu_strtosz(), qemu_strtosz_mebi() and
qemu_strtosz_metric() similar to qemu_strtoi64(), except negative
values are rejected.
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com >
Cc: Eduardo Habkost <ehabkost@redhat.com > (maintainer:X86)
Cc: Kevin Wolf <kwolf@redhat.com > (supporter:Block layer core)
Cc: Max Reitz <mreitz@redhat.com > (supporter:Block layer core)
Cc: qemu-block@nongnu.org (open list:Block layer core)
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com >
Message-Id: <1487708048-2131-23-git-send-email-armbru@redhat.com >
2017-02-23 20:35:36 +01:00
4fcdf65ae2
util/cutils: Let qemu_strtosz*() optionally reject trailing crap
...
Change the qemu_strtosz() & friends to return -EINVAL when @endptr is
null and the conversion doesn't consume the string completely.
Matches how qemu_strtol() & friends work.
Only test_qemu_strtosz_simple() passes a null @endptr. No functional
change there, because its conversion consumes the string.
Simplify callers that use @endptr only to fail when it doesn't point
to '\0' to pass a null @endptr instead.
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com >
Cc: Eduardo Habkost <ehabkost@redhat.com > (maintainer:X86)
Cc: Kevin Wolf <kwolf@redhat.com > (supporter:Block layer core)
Cc: Max Reitz <mreitz@redhat.com > (supporter:Block layer core)
Cc: qemu-block@nongnu.org (open list:Block layer core)
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com >
Message-Id: <1487708048-2131-22-git-send-email-armbru@redhat.com >
2017-02-23 20:35:36 +01:00
466dea14e6
util/cutils: New qemu_strtosz()
...
Most callers of qemu_strtosz_suffix() pass QEMU_STRTOSZ_DEFSUFFIX_B.
Capture the pattern in new qemu_strtosz().
Inline qemu_strtosz_suffix() into its only remaining caller.
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
Message-Id: <1487708048-2131-17-git-send-email-armbru@redhat.com >
2017-02-23 20:35:36 +01:00
ca6b6e1e68
Don't check qobject_type() before qobject_to_qdict()
...
qobject_to_qdict(obj) returns NULL when obj isn't a QDict. Check
that instead of qobject_type(obj) == QTYPE_QDICT.
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <1487363905-9480-8-git-send-email-armbru@redhat.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
2017-02-22 19:52:01 +01:00
b166099712
QAPI: Fix blockdev-add example documentation
...
Signed-off-by: Jeff Cody <jcody@redhat.com >
2017-02-21 10:37:46 -05:00
31eb1202d3
iscsi: Add blockdev-add support
...
This adds blockdev-add support for iscsi devices.
Reviewed-by: Daniel P. Berrange <berrange@redhat.com >
Reviewed-by: Fam Zheng <famz@redhat.com >
Signed-off-by: Kevin Wolf <kwolf@redhat.com >
Signed-off-by: Jeff Cody <jcody@redhat.com >
2017-02-21 10:37:34 -05:00
c86f106b85
report guest crash information in GUEST_PANICKED event
...
it's not very convenient to use the crash-information property interface,
so provide a CPU class callback to get the guest crash information, and pass
that information in the event
Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com >
Signed-off-by: Denis V. Lunev <den@openvz.org >
Message-Id: <1487053524-18674-3-git-send-email-den@openvz.org >
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2017-02-16 15:30:49 +01:00
7f4076c1bb
trace: clean up trace-events files
...
There are a number of unused trace events that
scripts/cleanup-trace-events.pl finds. The "hw/vfio/pci-quirks.c"
filename was typoed and "qapi/qapi-visit-core.c" was missing the qapi/
directory prefix.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
Message-id: 20170126171613.1399-3-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com >
2017-01-31 17:12:15 +00:00
6514532f73
qapi: add missing trace_visit_type_enum() call
...
A trace event exists for enums but it's never called. This patch fixes
this oversight so that enums are traced just like the other QAPI types.
Suggested-by: Daniel P. Berrange <berrange@redhat.com >
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
Message-id: 20170126171613.1399-2-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com >
2017-01-31 17:11:28 +00:00
5d0c7f4f9e
qapi: Remove unwanted commas after #optional keyword
...
We don't want that commas to be part of the generated documentation,
so remove them.
Signed-off-by: Stefan Weil <sw@weilnetz.de >
Message-Id: <20170122145407.27476-1-sw@weilnetz.de >
Reviewed-by: Markus Armbruster <armbru@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-27 08:23:06 +01:00
231aaf3a82
qmp-events: move 'MIGRATION_PASS' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:50 +01:00
a102a4acad
qmp-events: move 'DUMP_COMPLETED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:50 +01:00
e602f0b4e7
qmp-events: move 'MEM_UNPLUG_ERROR' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:50 +01:00
14df1ea168
qmp-events: move 'VSERPORT_CHANGE' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:50 +01:00
2ee7fea7ce
qmp-events: move 'QUORUM_REPORT_BAD' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:50 +01:00
9dcbe9a7e8
qmp-events: move 'QUORUM_FAILURE' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:50 +01:00
449dbec15a
qmp-events: move 'GUEST_PANICKED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
a030dc0029
qmp-events: move 'BALLOON_CHANGE' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
622b3a6a51
qmp-events: move 'ACPI_DEVICE_OST' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
bce911ce26
qmp-events: move 'MIGRATION' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
e6bcb080f9
qmp-events: move 'SPICE_MIGRATE_COMPLETED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
93ab0fc3c3
qmp-events: move 'SPICE_DISCONNECTED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
da08e2a5a2
qmp-events: move 'SPICE_INITIALIZED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
5db6670347
qmp-events: move 'SPICE_CONNECTED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
659789ba36
qmp-events: move 'VNC_DISCONNECTED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
99ab2471a4
qmp-events: move 'VNC_INITIALIZED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
f46052fd13
qmp-events: move 'VNC_CONNECTED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
5dbdcf4324
qmp-events: move 'NIC_RX_FILTER_CHANGED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
cdc94a1b3e
qmp-events: move 'DEVICE_DELETED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
9ba5cec9dd
qmp-events: move 'WATCHDOG' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
73c41bfd31
qmp-events: move 'RTC_CHANGE' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
aa496f9812
qmp-events: move 'WAKEUP' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
4de62c38a5
qmp-events: move 'SUSPEND_DISK' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
6f3cc5406b
qmp-events: move 'SUSPEND' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
a2235a0499
qmp-events: move 'RESUME' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:48 +01:00
138c454c0f
qmp-events: move 'STOP' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:48 +01:00
7a2aae7a36
qmp-events: move 'RESET' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:48 +01:00
189d43bed6
qmp-events: move 'POWERDOWN' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:48 +01:00
12defe50f8
qmp-events: move 'SHUTDOWN' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:48 +01:00
01b7d4be5c
qmp-events: move 'DEVICE_TRAY_MOVED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:48 +01:00
11a3dee1b9
qmp-events: move 'BLOCK_JOB_READY' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:48 +01:00
af0e09106c
qmp-events: move 'BLOCK_JOB_ERROR' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:48 +01:00
e161df3939
qmp-events: move 'BLOCK_JOB_CANCELLED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:48 +01:00
e21e65b212
qmp-events: move 'BLOCK_JOB_COMPLETED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:48 +01:00
07c9f583d5
qmp-events: move 'BLOCK_IO_ERROR' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:48 +01:00
370d4eba7d
qmp-events: move 'BLOCK_IMAGE_CORRUPTED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:48 +01:00
f6235a256f
qmp-commands: move 'blockdev-mirror' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:47 +01:00
