9e722ebc06
util: vfio-helpers: use ARRAY_SIZE in qemu_vfio_init_pci()
...
Cc: qemu-trivial@nongnu.org
Signed-off-by: Li Qiang <liq3ea@gmail.com >
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com >
Message-Id: <1543571638-2892-1-git-send-email-liq3ea@gmail.com >
Signed-off-by: Laurent Vivier <laurent@vivier.eu >
2018-12-11 18:28:47 +01:00
549b50a31d
vfio-helpers: Fix qemu_vfio_open_pci() crash
...
qemu_vfio_open_common() initializes s->lock only after passing s to
qemu_vfio_dma_map() via qemu_vfio_init_ramblock().
qemu_vfio_dma_map() tries to lock the uninitialized lock and crashes.
Fix by initializing s->lock first.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1645840
Fixes: 418026ca43
Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Cornelia Huck <cohuck@redhat.com >
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com >
Message-id: 20181127084143.1113-1-armbru@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org >
2018-11-27 18:39:32 +00:00
d29eb678bc
replace functions which are only available in glib-2.24
...
Currently the minimal supported version of glib is 2.22.
Since testing is done with a glib that claims to be 2.22, but in fact
has APIs from newer version of glib, this bug was not caught during
submit of the patch referenced below.
Replace g_realloc_n, which is available only since 2.24, with g_renew.
Fixes commit 418026ca43
("util: Introduce vfio helpers")
Signed-off-by: Olaf Hering <olaf@aepfle.de >
Reviewed-by: Thomas Huth <thuth@redhat.com >
Reviewed-by: Cornelia Huck <cohuck@redhat.com >
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru >
CC: qemu-stable@nongnu.org
2018-05-20 08:55:01 +03:00
78d8c99e29
block/nvme: fix Coverity reports
...
1) string not null terminated in sysfs_find_group_file
2) NULL pointer dereference and dead local variable in nvme_init.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
Signed-off-by: Fam Zheng <famz@redhat.com >
Message-Id: <20180213015240.9352-1-famz@redhat.com >
Signed-off-by: Fam Zheng <famz@redhat.com >
2018-03-01 15:21:46 +08:00
418026ca43
util: Introduce vfio helpers
...
This is a library to manage the host vfio interface, which could be used
to implement userspace device driver code in QEMU such as NVMe or net
controllers.
Signed-off-by: Fam Zheng <famz@redhat.com >
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com >
Message-Id: <20180116060901.17413-3-famz@redhat.com >
Signed-off-by: Fam Zheng <famz@redhat.com >
2018-02-08 09:22:03 +08:00