6a8a8b62bd
include/hw/ide: Unexport pci_piix3_xen_ide_unplug()
...
This function was declared in a generic and public header, implemented
in a device-specific source file but only used in xen_platform. Given its
'aux' parameter, this function is more xen-specific than piix-specific.
Also, the hardcoded magic constants seem to be generic and related to
PCIIDEState and IDEBus rather than piix.
Therefore, move this function to xen_platform, unexport it, and drop the
"piix3" in the function name as well.
Signed-off-by: Bernhard Beschow <shentey@gmail.com >
Reviewed-by: Paul Durrant <paul@xen.org >
Acked-by: Anthony PERARD <anthony.perard@citrix.com >
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org >
Message-Id: <20220513180957.90514-4-shentey@gmail.com >
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com >
2022-06-09 14:47:42 +01:00
d475fb1252
hw/ide: Move MAX_IDE_DEVS define to hw/ide/internal.h
...
We can move this define now that less files use it to internal.h to
further reduce dependency on hw/ide.h.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu >
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk >
Reviewed-by: Markus Armbruster <armbru@redhat.com >
Message-id: e68675d2f6252f229cf788b7cd163bb76fa3e26b.1584457537.git.balaton@eik.bme.hu
Signed-off-by: John Snow <jsnow@redhat.com >
2020-03-17 12:22:36 -04:00
5a6ac100f6
hw/ide: Remove now unneded #include "hw/pci/pci.h" from hw/ide.h
...
After previous patches we don't need hw/pci/pci.h any more in
hw/ide.h. Some files depended on implicit inclusion by this header
which are also fixed up here.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu >
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk >
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com >
Reviewed-by: Markus Armbruster <armbru@redhat.com >
Message-id: 444a5e34331bf1f7880541b8d46e0353f470f5a6.1584457537.git.balaton@eik.bme.hu
Signed-off-by: John Snow <jsnow@redhat.com >
2020-03-17 12:22:36 -04:00
f42b65b8a0
hw/ide: Get rid of piix4_init function
...
This removes pci_piix4_ide_init() function similar to clean up done to
other ide devices.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu >
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk >
Reviewed-by: Markus Armbruster <armbru@redhat.com >
Message-id: fe46b6536abbae77695f6d1c711a04a3f4b5481d.1584457537.git.balaton@eik.bme.hu
Signed-off-by: John Snow <jsnow@redhat.com >
2020-03-17 12:22:36 -04:00
df45d38f73
hw/ide: Get rid of piix3_init functions
...
This removes pci_piix3_ide_init() and pci_piix3_xen_ide_init()
functions similar to clean up done to other ide devices.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu >
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk >
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com >
Reviewed-by: Markus Armbruster <armbru@redhat.com >
Message-id: adddfa21552783020d64e1314318cab6d24362c3.1584457537.git.balaton@eik.bme.hu
Signed-off-by: John Snow <jsnow@redhat.com >
2020-03-17 12:22:36 -04:00
c06cde44eb
ide/via: Get rid of via_ide_init()
...
Follow example of CMD646 and remove via_ide_init function and do it
directly in board code instead.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu >
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk >
Tested-by: BALATON Zoltan <balaton@eik.bme.hu >
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk >
Message-id: 20200313082444.2439-3-mark.cave-ayland@ilande.co.uk
Signed-off-by: John Snow <jsnow@redhat.com >
2020-03-16 21:08:21 -04:00
d32a4f3bdf
cmd646: remove unused pci_cmd646_ide_init() function
...
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk >
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com >
Message-id: 20200307091313.24190-3-mark.cave-ayland@ilande.co.uk
Signed-off-by: John Snow <jsnow@redhat.com >
2020-03-10 14:50:13 -04:00
7dd687ba1b
ide/via: Rename functions to match device name
...
The device is called via-ide and the modelled IDE controller is not
specific to 82C686B but is also usable independently. Therefore, change
function name prefixes accordingly to match device name.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu >
Message-id: 2905ced862c8d2ad509d73152171ce2472d72605.1548160772.git.balaton@eik.bme.hu
Signed-off-by: John Snow <jsnow@redhat.com >
2019-01-25 14:52:12 -05:00
ae4d2eb273
xen-platform: add missing disk unplug option
...
The Xen HVM unplug protocol [1] specifies a mechanism to allow guests to
request unplug of 'aux' disks (which is stated to mean all IDE disks,
except the primary master). This patch adds support for that unplug request.
NOTE: The semantics of what happens if unplug of all disks and 'aux' disks
is simultaneously requests is not clear. The patch makes that
assumption that an 'all' request overrides an 'aux' request.
[1] http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/misc/hvm-emulated-unplug.markdown
Signed-off-by: Paul Durrant <paul.durrant@citrix.com >
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org >
----
Cc: Stefano Stabellini <sstabellini@kernel.org >
Cc: Anthony Perard <anthony.perard@citrix.com >
Cc: Paolo Bonzini <pbonzini@redhat.com >
Cc: Richard Henderson <rth@twiddle.net >
Cc: Eduardo Habkost <ehabkost@redhat.com >
Cc: "Michael S. Tsirkin" <mst@redhat.com >
Cc: John Snow <jsnow@redhat.com >
2017-01-27 15:23:29 -08:00
15e8159e76
Call pci_piix3_xen_ide_unplug from unplug_disks
...
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com >
Acked-by: Paolo Bonzini <pbonzini@redhat.com >
2014-02-20 17:28:08 +00:00
0d09e41a51
hw: move headers to include/
...
Many of these should be cleaned up with proper qdev-/QOM-ification.
Right now there are many catch-all headers in include/hw/ARCH depending
on cpu.h, and this makes it necessary to compile these files per-target.
However, fixing this does not belong in these patches.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2013-04-08 18:13:10 +02:00