be1765f398
hw/ide: Do ide_drive_get() within pci_ide_create_devs()
...
The pci_ide_create_devs() function takes a hd_table parameter but all
callers just pass what ide_drive_get() returns so we can do it locally
simplifying callers and removing hd_table parameter.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu >
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk >
Reviewed-by: Markus Armbruster <armbru@redhat.com >
Message-id: e9713fdded4d212fa68ed03b844e531934226a6f.1584457537.git.balaton@eik.bme.hu
Signed-off-by: John Snow <jsnow@redhat.com >
2020-03-17 12:22:36 -04:00
5a6ac100f6
hw/ide: Remove now unneded #include "hw/pci/pci.h" from hw/ide.h
...
After previous patches we don't need hw/pci/pci.h any more in
hw/ide.h. Some files depended on implicit inclusion by this header
which are also fixed up here.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu >
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk >
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com >
Reviewed-by: Markus Armbruster <armbru@redhat.com >
Message-id: 444a5e34331bf1f7880541b8d46e0353f470f5a6.1584457537.git.balaton@eik.bme.hu
Signed-off-by: John Snow <jsnow@redhat.com >
2020-03-17 12:22:36 -04:00
8ac98d1a97
ide: Get rid of CMD646BAR struct
...
Now that no CMD646 specific parts are left in CMD646BAR (all remaining
members are really PCI IDE specific) this struct can be deleted moving
the memory regions for PCI IDE BARs to PCIIDEState where they better
belong. The CMD646 PCI IDE model is adjusted accordingly.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu >
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk >
Reviewed-by: John Snow <jsnow@redhat.com >
Message-id: 4b6cb2ae150dc0d21178209e4beb1e35140a7325.1547166960.git.balaton@eik.bme.hu
Signed-off-by: John Snow <jsnow@redhat.com >
2019-01-25 14:52:11 -05:00
c9ebc75dc2
cmd646: Move PCI IDE specific functions to ide/pci.c
...
The io mem ops callbacks are not specific to CMD646 but really follow
the PCI IDE spec so move these from cmd646.c to pci.c to allow other
PCI IDE implementations to use them.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu >
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk >
Reviewed-by: John Snow <jsnow@redhat.com >
Message-id: a2b1b2b74afdc78330b8b75605687f683a249635.1547166960.git.balaton@eik.bme.hu
Signed-off-by: John Snow <jsnow@redhat.com >
2019-01-25 14:52:11 -05:00
e210ec87b9
cmd646: Remove IDEBus from CMD646BAR
...
The cmd646 io mem ops callbacks only need the IDEBus which is
currently passed via a CMD646BAR struct. No need to wrap it up like
that, we can pass it directly to these callbacks which then allows to
drop the IDEBus from the CMD646BAR.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu >
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk >
Reviewed-by: John Snow <jsnow@redhat.com >
Message-id: 7a31c155c9899869794499d841d30c7ef32aae47.1547166960.git.balaton@eik.bme.hu
Signed-off-by: John Snow <jsnow@redhat.com >
2019-01-25 14:52:11 -05:00
2ab2ef0785
cmd646: Remove unused variable
...
There was a pointer to PCIIDEState in CMD646BAR which was set but
not used afterwards. Get rid of this unused variable.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu >
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk >
Reviewed-by: John Snow <jsnow@redhat.com >
Message-id: 1e352f091aa601fb2e19771aac46529fe278dd91.1547166960.git.balaton@eik.bme.hu
Signed-off-by: John Snow <jsnow@redhat.com >
2019-01-25 14:52:11 -05:00
a9c94277f0
Use #include "..." for our own headers, <...> for others
...
Tracked down with an ugly, brittle and probably buggy Perl script.
Also move includes converted to <...> up so they get included before
ours where that's obviously okay.
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
Tested-by: Eric Blake <eblake@redhat.com >
Reviewed-by: Richard Henderson <rth@twiddle.net >
2016-07-12 16:19:16 +02:00
e8ad4d1680
ide: move headers to include folder
...
The patch moves "hw/ide/achi.h", "hw/ide/pci.h" and "hw/ide/internal.h" headers
to corresponding folders inside "include" folder alike other Qemu headers.
Signed-off-by: Efimov Vasily <real@ispras.ru >
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2016-06-29 14:03:45 +02:00
