df9bb6660d
usb-mtp: convert init to realize
...
Signed-off-by: Gonglei <arei.gonglei@huawei.com >
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com >
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2014-09-23 12:51:07 +02:00
d0657b2aab
usb: don't use 'Yoda conditions'
...
imitate nearby code about using '!value' or 'value == NULL'
Signed-off-by: Gonglei <arei.gonglei@huawei.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru >
2014-08-15 18:54:06 +04:00
cf679caf91
usb: mtp: tag root property as experimental
...
Reason: we don't want commit to that interface yet. Possibly
the implementation will be switched over to use fsdev.
Suggested-by: Paolo Bonzini <pbonzini@redhat.com >
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2014-07-23 08:55:40 +02:00
13d54125a3
mtp: linux guest detection fix.
...
Attach a name to the MTP interface (android phones have this too).
With this patch recent linux guests such as fedora 20 happily detect and
use the device. It shows up in nautilus file manager automatically, and
simple-mtpfs can mount it.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2014-07-11 12:31:41 +02:00
22513a9b44
usb-mtp: handle usb_mtp_get_object failure
...
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com >
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2014-05-26 08:41:07 +02:00
68206d7342
usb-mtp: handle lseek failure
...
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com >
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2014-05-26 08:41:07 +02:00
36084d7e31
usb-mtp: use bool to track MTPObject init status
...
Stop setting nchildren to -1. Use separate bool variable to track
whenever we've already fetched the child objects instead.
Also make nchildren unsigned.
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com >
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2014-05-26 08:41:07 +02:00
8ebb876357
usb: mtp: reply INCOMPLETE_TRANSFER on read errors
...
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Reviewed-by: Peter Wu <peter@lekensteyn.nl >
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com >
2014-05-05 12:58:02 +02:00
afa82daf16
usb: mtp: fix possible buffer overflow
...
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Reviewed-by: Peter Wu <peter@lekensteyn.nl >
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com >
2014-05-05 12:57:58 +02:00
9cd04ccf75
usb: mtp: drop data-out hexdump
...
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Reviewed-by: Peter Wu <peter@lekensteyn.nl >
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com >
2014-05-05 12:57:53 +02:00
457d397a24
usb: mtp: avoid empty description string
...
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Reviewed-by: Peter Wu <peter@lekensteyn.nl >
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com >
2014-05-05 12:57:49 +02:00
2dc7fdf33d
usb: mtp: fix error path memory leak
...
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Reviewed-by: Peter Wu <peter@lekensteyn.nl >
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com >
2014-05-05 12:57:45 +02:00
9e4eff5b54
usb: mtp: fix serial (must be exact 32 chars)
...
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Reviewed-by: Peter Wu <peter@lekensteyn.nl >
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com >
2014-05-05 12:57:41 +02:00
f7eaed8555
usb: mtp: fix version (is decimal not bcd)
...
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Reviewed-by: Peter Wu <peter@lekensteyn.nl >
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com >
2014-05-05 12:57:35 +02:00
ada435f47e
usb: mtp: fix usb_mtp_add_u64
...
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Reviewed-by: Peter Wu <peter@lekensteyn.nl >
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com >
2014-05-05 12:57:30 +02:00
1c76551fae
usb: mtp: replace debug printfs with trace points
...
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
Reviewed-by: Peter Wu <peter@lekensteyn.nl >
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com >
2014-05-05 12:57:21 +02:00
840a178c94
usb: mtp filesharing
...
Implementation of a USB Media Transfer Device device for easy
filesharing. Read-only. No access control inside qemu, it will
happily export any file it is able to open to the guest, i.e.
standard unix access rights for the qemu process apply.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com >
2014-04-23 10:28:14 +02:00