mirror of
https://github.com/mii443/qemu.git
synced 2025-08-22 23:25:48 +00:00
block: bdrv_append(): don't consume reference
We have too much comments for this feature. It seems better just don't do it. Most of real users (tests don't count) have to create additional reference. Drop also comment in external_snapshot_prepare: - bdrv_append doesn't "remove" old bs in common sense, it sounds strange - the fact that bdrv_append can fail is obvious from the context - the fact that we must rollback all changes in transaction abort is known (it's the direct role of abort) Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com> Message-Id: <20210428151804.439460-5-vsementsov@virtuozzo.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
committed by
Kevin Wolf
parent
397f7cc0c2
commit
ae9d441706
@ -312,6 +312,7 @@ void commit_start(const char *job_id, BlockDriverState *bs,
|
||||
commit_top_bs->total_sectors = top->total_sectors;
|
||||
|
||||
ret = bdrv_append(commit_top_bs, top, errp);
|
||||
bdrv_unref(commit_top_bs); /* referenced by new parents or failed */
|
||||
if (ret < 0) {
|
||||
commit_top_bs = NULL;
|
||||
goto fail;
|
||||
|
Reference in New Issue
Block a user