mirror of
https://github.com/mii443/qemu.git
synced 2025-12-03 11:08:25 +00:00
build: move COLO under CONFIG_REPLICATION
We don't allow to use x-colo capability when replication is not
configured. So, no reason to build COLO when replication is disabled,
it's unusable in this case.
Note also that the check in migrate_caps_check() is not the only
restriction: some functions in migration/colo.c will just abort if
called with not defined CONFIG_REPLICATION, for example:
migration_iteration_finish()
case MIGRATION_STATUS_COLO:
migrate_start_colo_process()
colo_process_checkpoint()
abort()
It could probably make sense to have possibility to enable COLO without
REPLICATION, but this requires deeper audit of colo & replication code,
which may be done later if needed.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Acked-by: Dr. David Alan Gilbert <dave@treblig.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <20230428194928.1426370-4-vsementsov@yandex-team.ru>
Signed-off-by: Juan Quintela <quintela@redhat.com>
This commit is contained in:
committed by
Juan Quintela
parent
4332ffcd7b
commit
51e47cf860
@@ -1052,6 +1052,7 @@ SRST
|
||||
migration (or once already in postcopy).
|
||||
ERST
|
||||
|
||||
#ifdef CONFIG_REPLICATION
|
||||
{
|
||||
.name = "x_colo_lost_heartbeat",
|
||||
.args_type = "",
|
||||
@@ -1060,6 +1061,7 @@ ERST
|
||||
"a failover or takeover is needed.",
|
||||
.cmd = hmp_x_colo_lost_heartbeat,
|
||||
},
|
||||
#endif
|
||||
|
||||
SRST
|
||||
``x_colo_lost_heartbeat``
|
||||
|
||||
Reference in New Issue
Block a user