mirror of
https://github.com/mii443/qemu.git
synced 2025-08-22 23:25:48 +00:00
Do not use %m in common code to print error messages
The %m format specifier is an extension from glibc - and when compiling QEMU for NetBSD, the compiler correctly complains, e.g.: /home/qemu/qemu-test.ELjfrQ/src/util/main-loop.c: In function 'sigfd_handler': /home/qemu/qemu-test.ELjfrQ/src/util/main-loop.c:64:13: warning: %m is only allowed in syslog(3) like functions [-Wformat=] printf("read from sigfd returned %zd: %m\n", len); ^ Let's use g_strerror() here instead, which is an easy-to-use wrapper around the thread-safe strerror_r() function. While we're at it, also convert the "printf()" in main-loop.c into the preferred "error_report()". Signed-off-by: Thomas Huth <thuth@redhat.com> Message-Id: <20191018130716.25438-1-thuth@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
committed by
Paolo Bonzini
parent
30d6ff662d
commit
372a87a1d9
@ -61,7 +61,8 @@ static void sigfd_handler(void *opaque)
|
||||
}
|
||||
|
||||
if (len != sizeof(info)) {
|
||||
printf("read from sigfd returned %zd: %m\n", len);
|
||||
error_report("read from sigfd returned %zd: %s", len,
|
||||
g_strerror(errno));
|
||||
return;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user