mii/qemu
1
0
Fork 0
mirror of https://github.com/mii443/qemu.git synced 2025-12-03 11:08:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

vhost: simplify vhost_dev_init() fail_busyloop label

Browse Source 
Requiring a conditional for every goto is tedious:

  if (busyloop_timeout) {
      goto fail_busyloop;
  } else {
      goto fail;
  }

Move the conditional to into the fail_busyloop label so that it's safe
to jump to this label unconditionally.

This change makes the migrate_add_blocker() error case more consistent.
It jumped to fail_busyloop unconditionally whereas the memslots limits
error case was conditional.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20210222114931.272308-1-stefanha@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Stefan Hajnoczi
2021-02-22 11:49:31 +00:00
committed by Michael S. Tsirkin
parent b52fa0ea45
commit 1d8d014e93
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
hw/virtio/vhost.c
View File

@@ -1388,18 +1388,16 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque,
error_report("vhost backend memory slots limit is less" error_report("vhost backend memory slots limit is less"
" than current number of present memory slots"); " than current number of present memory slots");
r = -1; r = -1;
if (busyloop_timeout) { goto fail_busyloop;
goto fail_busyloop;
} else {
goto fail;
}
} }
return 0; return 0;
fail_busyloop: fail_busyloop:
while (--i >= 0) { if (busyloop_timeout) {
vhost_virtqueue_set_busyloop_timeout(hdev, hdev->vq_index + i, 0); while (--i >= 0) {
vhost_virtqueue_set_busyloop_timeout(hdev, hdev->vq_index + i, 0);
}
} }
fail: fail:
hdev->nvqs = n_initialized_vqs; hdev->nvqs = n_initialized_vqs;