mii/qemu
1
0
Fork 0
mirror of https://github.com/mii443/qemu.git synced 2025-08-31 03:19:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

qapi: Drop unused error argument for list and implicit struct

Browse Source 
No backend was setting an error when ending the visit of a list or
implicit struct, or when moving to the next list node.  Make the
callers a bit easier to follow by making this a part of the contract,
and removing the errp argument - callers can then unconditionally end
an object as part of cleanup without having to think about whether a
second error is dominated by a first, because there is no second
error.

A later patch will then tackle the larger task of splitting
visit_end_struct(), which can indeed set an error.

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1454075341-13658-24-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
Eric Blake
2016-01-29 06:48:59 -07:00
committed by Markus Armbruster
parent bdd8e6b5d8
commit 08f9541dec
11 changed files with 41 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
qapi/string-input-visitor.c
View File

@ -1,7 +1,7 @@
/*
* String parsing visitor
*
* Copyright Red Hat, Inc. 2012
* Copyright Red Hat, Inc. 2012-2016
*
* Author: Paolo Bonzini <pbonzini@redhat.com>
*
@ -139,8 +139,7 @@ start_list(Visitor *v, const char *name, Error **errp)
}
}
static GenericList *
next_list(Visitor *v, GenericList **list, Error **errp)
static GenericList *next_list(Visitor *v, GenericList **list)
{
StringInputVisitor *siv = to_siv(v);
GenericList **link;
@ -178,8 +177,7 @@ next_list(Visitor *v, GenericList **list, Error **errp)
return *link;
}
static void
end_list(Visitor *v, Error **errp)
static void end_list(Visitor *v)
{
StringInputVisitor *siv = to_siv(v);
siv->head = true;