Android NDK r28 is released with 16 KiB page size compatibility option
enabled by default [1].
Let's update our Dockerfile to make it clear that libmozc.so is
compatible with 16 KiB page size.
[1]: https://github.com/android/ndk/releases/tag/r28
PiperOrigin-RevId: 725115333
This follows up to my previous commit [1], which aimed to make
'rules_android_ndk' compatible with 'allow_empty_glob' (#1150) with our own
local patch.
As rules_android_ndk 0.1.13 does include the fix [2], we no longer need to
keep maintaining our local patch.
[1]: 990c417cd4
[2]: https://github.com/bazelbuild/rules_android_ndk/pull/98
PiperOrigin-RevId: 725114927
* Fixed the unused error in process_watch_dog_test.cc
* Fixed the non-virtual destructor error in com_inplements_test.cc
#codehealth
PiperOrigin-RevId: 725105920
* Fixed problems related to date conversion function, etc.
Resolved a minor issue where a recent typographical error temporarily disabled the date conversion function and other functions.
Fix typos:
DATA => DATE
REWRITERS => REWRITER
MOZC_DATA_REWRITER => MOZC_DATE_REWRITER
MOZC_DATE_REWRITERS => MOZC_DATE_REWRITER
MOZC_FORTUNE_REWRITERS => MOZC_FORTUNE_REWRITER
* Fixed an unmodified comment when moving SessionConverter from session/ to engine/.
MOZC_SESSION_SESSION_CONVERTER_INTERFACE_H_ => MOZC_ENGINE_SESSION_CONVERTER_INTERFACE_H_
PiperOrigin-RevId: 723805096
* The behavior should not be changed.
* Add CreateAlternativeCandidate to extract a logic of a new candidate creation from RewriteSegment.
#codehealth
PiperOrigin-RevId: 722525552
There are two orthogonal categories for two candidates.
* {primary, secondary}: The primary candidate ranked higher than secondary.
If the user has configured half-width value as primary, full-width value
will be secondary.
* {original, alternative}: Original is the candidate that already exists in
the segment before this rewriter. The original candidate is used as the
input to this rewriter. Alternative is the candidate that is generated
from the original candidate.
#codehelath
PiperOrigin-RevId: 722525279
* The behavior should not be changed.
* original_candidate keeps the original value.
* new_candidate takes the alternative value.
* when the original value is not used, this CL will remove the original_candidate instead of replacing the value of the original_candidate.
PiperOrigin-RevId: 722525026
Automated g4 rollback of changelist 720933777.
*** Reason for rollback ***
rollback
*** Original change description ***
Automated g4 rollback of changelist 720920580.
*** Reason for rollback ***
TAP has detected 10 or more targets failed to build at cl/720920580.
***
PiperOrigin-RevId: 722489068
NumberRewriter may be called multiple times in the conversion step.
For example, DictionaryPredictor calls Converter again with Segments
that is already processed before. As result, NumberRewriter is called twice.
However, NumberRewriter should not change Segments twice.
This CL fixes this issue.
#codehealth
PiperOrigin-RevId: 721302816
*** Reason for rollback ***
TAP has detected 10 or more targets failed to build at cl/720920580.
*** Original change description ***
Removed SessionInterface and SessionHandlerInteface.
These interfaces are not used. We would like to use Interface when polymorphism is necessary.
***
PiperOrigin-RevId: 720933777
