mii/RustySecrets
1
0
Fork 0
mirror of https://github.com/mii443/RustySecrets.git synced 2025-08-22 16:25:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor improvement to validation

Browse Source
This commit is contained in:
Noah Vesely
2018-03-29 01:26:44 -06:00
committed by Romain Ruetschi
parent 3f215cdb39
commit 71064a686e
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/share/validation.rs
View File

@ -34,11 +34,9 @@ pub(crate) fn validate_shares<S: IsShare>(shares: &Vec<S>) -> Result<(u8, usize)
let mut slen = 0;
for share in shares {
let (id, threshold_, slen_) = (
share.get_id(),
share.get_threshold(),
share.get_data().len(),
);
let id = share.get_id();
let threshold_ = share.get_threshold();
let slen_ = share.get_data().len();
// Public-facing `Share::share_from_string` performs these three tests, but in case another
// type which implements `IsShare` is implemented later that doesn't do that validation,
@ -75,6 +73,8 @@ pub(crate) fn validate_shares<S: IsShare>(shares: &Vec<S>) -> Result<(u8, usize)
ids.push(id);
}
// Only once the threshold is confirmed as consistent should we determine if shares are
// missing.
if shares_count < threshold as usize {
bail!(ErrorKind::MissingShares(shares_count, threshold))
}