Commit Graph

8 Commits

Author SHA1 Message Date
Miwa / Ensan
eb040124e7 fix: add more test cases 2025-03-30 17:20:07 +09:00
Miwa
e8f9eb2f80 Update testConvertToTimeExpression to use await for KanaKanjiConverter initialization
* Change `let converter = KanaKanjiConverter()` to `let converter = await KanaKanjiConverter()`
2025-03-30 16:58:10 +09:00
Miwa
feb5daa5bb Update convertToTimeExpression function to handle edge cases and correct time validation
* **TimeExpression.swift**
  - Change the validation for 3-digit numbers to allow last two digits between 00-59.
  - Change the validation for 4-digit numbers to allow first two digits between 00-24 and last two digits between 00-59.

* **TimeExpressionTests.swift**
  - Update test cases to reflect the new validation rules.
  - Change test input "1360" to "2440" and update expected results accordingly.
  - Update assertions for the modified test cases.
2025-03-30 16:57:46 +09:00
Miwa
19dbbccd9f Add test cases for convertToTimeExpression function
* **Test cases**
  - Create `KanaKanjiConverter` instance
  - Use `makeDirectInput` to create `ComposingText` instances for test cases
  - Call `convertToTimeExpression` function with different inputs
  - Verify the results using `XCTAssertEqual` and `XCTAssertTrue`

* **Helper function**
  - Add `makeDirectInput(direct input: String) -> ComposingText` helper function

* **Concurrency**
  - Use `await` for the call of `convertToTimeExpression`
  - Call `convertToTimeExpression` outside of XCTest function
2025-03-30 16:55:34 +09:00
Miwa
65ac2fa3aa Update testConvertToTimeExpression function to use await for convertToTimeExpression calls
* Ensure `convertToTimeExpression` function is called asynchronously in all test cases
2025-03-30 16:48:17 +09:00
Miwa
ac8dfc8dc3 Update test cases for current convertToTimeExpression signature
* Add makeDirectInput function to create ComposingText instances
* Update testConvertToTimeExpression to use makeDirectInput for input conversion
2025-03-30 16:44:45 +09:00
Miwa
3b6d63c8d3 Add async/await to test functions in TimeExpressionTests.swift
* **testConvertToTimeExpression**
  - Change function signature to `async throws`
  - Initialize `KanaKanjiConverter` with `await`

* **testToTimeExpressionCandidates**
  - Change function signature to `async throws`
  - Initialize `KanaKanjiConverter` with `await`
2025-03-30 16:38:22 +09:00
Miwa
ad580d5214 feat: Add time expression conversion function
Fixes #170

Add functionality to convert 3-digit and 4-digit numbers into time expressions in the format 'HH:MM'.

* Add `convertToTimeExpression` function in `Sources/KanaKanjiConverterModule/Converter/TimeExpression.swift` to handle the conversion.
* Modify `Sources/KanaKanjiConverterModule/Converter/KanaKanjiConverter.swift` to include the new function and call it within `getWiseCandidate`.
* Add tests in `Tests/KanaKanjiConverterModuleTests/ConverterTests/TimeExpressionTests.swift` to ensure the new function works correctly.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/azooKey/AzooKeyKanaKanjiConverter/issues/170?shareId=XXXX-XXXX-XXXX-XXXX).
2025-03-30 16:32:25 +09:00